fix type and formatting of deployment_arns variable #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/codefresh run test |
1 similar comment
|
/codefresh run test |
|
/rebuild-readme |
|
/rebuild-readme |
|
/codefresh run test |
maximmi
approved these changes
Mar 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current type of var.deployment_arns is set as map(string). This expects both the key and value to be of type string. The proper type is map(string, list(string)). I don't think terraform supports this level of type declaration. The object type does not seem to work here since we dont know the names of all the keys (i.e. they map to user defined arns).
I changed the type to map(any) which fixed the type error, but then fails when trying to format the variable into the underlying IAM policy document. The fix was easy here, changed format -> formatlist and added a flatten to collapse the nested lists.
This unblocked me and I was able to successfully apply the module when setting deployment_arns to the non-default empty object.