Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add possible disable logs for s3 #63

Merged
merged 2 commits into from
Jun 11, 2021
Merged

Conversation

ByJacob
Copy link
Contributor

@ByJacob ByJacob commented Jun 11, 2021

what

  • add possible disable create logs bucket and configuration for s3

why

  • sometimes logs for s3 website isn't required :)

references

  • don't create issue

@ByJacob ByJacob requested review from a team as code owners June 11, 2021 13:44
@ByJacob ByJacob requested review from dotCipher and nitrocode and removed request for a team June 11, 2021 13:44
@korenyoni
Copy link
Member

/test all

@korenyoni
Copy link
Member

@ByJacob our validate-codeowners workflow did not run

Are you able to do the following?

$ git commit --amend (do not change anything)
$ git push [your origin and branch] --force

This will retrigger all of the workflows, including validate-codeowners

korenyoni
korenyoni previously approved these changes Jun 11, 2021
Copy link
Member

@korenyoni korenyoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@ByJacob
Copy link
Contributor Author

ByJacob commented Jun 11, 2021

@ByJacob our validate-codeowners workflow did not run

Are you able to do the following?

$ git commit --amend (do not change anything)
$ git push [your origin and branch] --force

This will retrigger all of the workflows, including validate-codeowners

I exec your commands

@korenyoni
Copy link
Member

/test all

@korenyoni korenyoni merged commit 972da8c into cloudposse:master Jun 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants