Fix: Adhere module.this.enabled
#66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
korenyoni
requested review from
dotCipher and
RothAndrew
and removed request for
a team
korenyoni
changed the title
module.this.enabled
|
/test all |
…aws-s3-website into fix/module-disable
|
/test all |
|
/test all |
nitrocode
previously approved these changes
Jul 2, 2021
|
/test all |
… Doing so causes issues in CI due to tests running in parallel.
|
/test all |
nitrocode
approved these changes
Jul 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
why
module.this.enabled. Resources are still created whenvar.enabled=false. This means that module invocations cannot reliably passvar.enabled=falsein situations where resources should not be created, for example if this module is invoked in test suites reused by multiple tests, some of them conditionally disabling this module when they do not need it.references