Adds flag and policy to require all buckets requests to be over SSL #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bradj
requested review from
adamcrews and
florian0410
and removed request for
a team
Benbentwo
previously approved these changes
Jul 22, 2021
|
/test all |
osterman
reviewed
Jul 22, 2021
main.tf
Outdated
| for_each = var.allow_ssl_requests_only ? [1] : [] | ||
|
|
||
| content { | ||
| sid = "ForceSSLOnlyAccess" |
There was a problem hiding this comment.
I feel like the language of the Sid should match the language of the feature flag
…form-aws-s3-website into only-allow-ssl-requests
|
/test all |
Benbentwo
approved these changes
Jul 22, 2021
aknysh
reviewed
Jul 22, 2021
| sid = "AllowSSLRequestsOnly" | ||
| effect = "Deny" | ||
| actions = ["s3:*"] | ||
| resources = [local.bucket_arn, "${local.bucket_arn}/*"] |
There was a problem hiding this comment.
@bradj we should have updated the bucket ARNs in the other places as well
resources = ["${aws_s3_bucket.default[0].arn}/*"]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
Adds flag that requires all S3 requests to be over SSL
why
Compliance and security
references
n/a