S3 resource supports AWS provider v4

[sreetejap]

what

• Modified aws_s3_bucket resource to support AWS provider v4.
• Upgraded cloudposse/s3-log-storage/aws module to 0.28.0 to support AWS provider v4.

why

• Current aws_s3_bucket resource does not support AWS provider v4.

[bridgecrew]

Bridgecrew has found infrastructure configuration errors in this PR ⬇️

[Nuru]

See below

Duplicate

[Nuru]

Our road map calls for S3 bucket resources to be provisioned with our s3-bucket module, with its inputs passed through where relevant, rather than to piecemeal update the S3 bucket resources everywhere. Therefore these changes are not acceptable. You can view cloudposse/terraform-aws-s3-log-storage#71 as an example.

The migration to s3-log-storage v0.28.0 has a high risk of data loss. Any module this is updating to this version needs, at a minimum:

• Explicit warnings about potential data loss
• A clear migration document detailing how to safely perform the migration
• A breaking change that will prevent automatic application of the upgrade in a situation that might trigger data loss

You can view the s3-log-storage migration documents as an example, and please note you do not need to copy or rewrite them, you can just reference them in the module-specific migration documents.

Once the module has been updated to the current s3-bucket and s3-log-storage modules and fully supports AWS provider v4, we will need to make an internal decision about version number changes. We may want to release this as v1.0.0 or v2.0.0.