Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade packages to support AWS v4 #80

Closed
wants to merge 5 commits into from

Conversation

johncblandii
Copy link

@johncblandii johncblandii commented Jul 1, 2022

what

  • Upgraded outdated packages and versions.tf

why

  • to support AWS v4 provider

references

@johncblandii johncblandii requested review from a team as code owners July 1, 2022 21:54
@johncblandii johncblandii requested review from Gowiem and Benbentwo and removed request for a team July 1, 2022 21:54
@johncblandii
Copy link
Author

/test all

main.tf Outdated Show resolved Hide resolved
versions.tf Outdated Show resolved Hide resolved
versions.tf Outdated Show resolved Hide resolved
@johncblandii
Copy link
Author

/test all

@johncblandii
Copy link
Author

johncblandii commented Jul 1, 2022

🤷🏽

TestExamplesComplete/Enabled 2022-07-01T22:36:49Z command.go:121: module.s3_website.module.logs.module.aws_s3_bucket.aws_s3_bucket.default[0]: Creating...
TestExamplesComplete/Disabled 2022-07-01T22:36:49Z command.go:121: ""
    examples_complete_test.go:109: 
        	Error Trace:	examples_complete_test.go:109
        	Error:      	Should be empty, but was ""
        	Test:       	TestExamplesComplete/Disabled

https://github.com/cloudposse/actions/runs/7157658521?check_suite_focus=true#step:9:679

@nitrocode
Copy link
Member

@johncblandii I believe this test fails because we're returning empty strings instead of null. I believe there was a discussion on it and we came to the conclusion that it's better to return an empty string.

The test probably needs to be updated because I think it's using an "exact search match" for the resource counts being zero.

// Verify we're getting back the outputs we expect
assert.Empty(t, s3BucketDomainName)

main.tf Outdated Show resolved Hide resolved
Co-authored-by: nitrocode <[email protected]>
@johncblandii
Copy link
Author

@johncblandii I believe this test fails because we're returning empty strings instead of null. I believe there was a discussion on it and we came to the conclusion that it's better to return an empty string.

The test probably needs to be updated because I think it's using an "exact search match" for the resource counts being zero.

// Verify we're getting back the outputs we expect
assert.Empty(t, s3BucketDomainName)

Makes sense. I'll update it later.

@arichtman
Copy link

Any chance we could get this moving again? I can take a crack at updating that test assertion?

@Nuru Nuru closed this in #93 Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support AWS Provider v4, Support latest context.tf
4 participants