-
-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade packages to support AWS v4 #80
Conversation
/test all |
/test all |
🤷🏽
https://github.com/cloudposse/actions/runs/7157658521?check_suite_focus=true#step:9:679 |
@johncblandii I believe this test fails because we're returning empty strings instead of null. I believe there was a discussion on it and we came to the conclusion that it's better to return an empty string. The test probably needs to be updated because I think it's using an "exact search match" for the resource counts being zero. terraform-aws-s3-website/test/src/examples_complete_test.go Lines 108 to 109 in 106b3e5
|
Co-authored-by: nitrocode <[email protected]>
Makes sense. I'll update it later. |
Any chance we could get this moving again? I can take a crack at updating that test assertion? |
what
versions.tf
why
references
context.tf
#75