Rename the exported security-group-inputs file to security-group-variables
#31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aknysh
added
the
no-release
|
/test all |
|
/test all |
nitrocode
reviewed
Dec 30, 2021
| @@ -1,6 +1,6 @@ | |||
| # security-group-inputs Version: 2 | |||
| # security-group-variables Version: 2 | |||
There was a problem hiding this comment.
should this version be bumped and use semver ?
There was a problem hiding this comment.
prob not related to the file name, but to the file content, which did not change
nitrocode
approved these changes
Dec 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
security-group-inputs.tffile tosecurity-group-variables.tfwhy
For example, we have
spotinst-variables.tffor Spot,security-group-variables.tffor SG, etc.