Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing deprecated overwrite option and associated docs and variable #27

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Removing deprecated overwrite option and associated docs and variable #27

wants to merge 3 commits into from
+7 −19

Conversation

bengaywins
Copy link

what

  • Remove the overwrite option on the SSM parameters

why

  • The overwrite option has been deprecated

references

@bengaywins bengaywins requested review from a team as code owners September 25, 2023 18:59
@bengaywins
Copy link
Author

@max-lobur I know you weren't tagged in this, but you seem to be a recent committer and GH says you work for CloudPosse. Can this get reviewed? Or possible to get whatever is the right team member(s) to review it?

@hans-d hans-d added wip Work in Progress: Not ready for final review or merge and removed wip Work in Progress: Not ready for final review or merge labels Mar 2, 2024
@hans-d
Copy link

hans-d commented Mar 2, 2024

/terratest

@mergify mergify bot added the triage Needs triage label Apr 9, 2024
@mergify Mergify
Copy link

mergify bot commented Apr 9, 2024

💥 This pull request now has conflicts. Could you fix it @bengaywins? 🙏

@mergify mergify bot added the conflict This PR has conflicts label Apr 9, 2024
@bengaywins
Copy link
Author

@hans-d I got the updates added to fix the CI checks! So ready for new testing whenever.

@mergify mergify bot removed the conflict This PR has conflicts label Apr 9, 2024
@joe-niland joe-niland added do not merge Do not merge this PR, doing so would cause problems and removed triage Needs triage labels Apr 10, 2024
@joe-niland
Copy link
Member

Hi @bengaywins
I discussed with other maintainers and we're going to hold on this one as the current situation with this deprecation does not appear to be finalised. Please see hashicorp/terraform-provider-aws#25636 (comment) for further info.

Probably once v6 of the AWS provider is released, we'll know how to proceed.

@bengaywins
Copy link
Author

Yeah I expected that @joe-niland! Thanks for the response.

@joe-niland joe-niland mentioned this pull request May 15, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamengual jamengual Awaiting requested review from jamengual jamengual is a code owner automatically assigned from cloudposse/contributors

@florian0410 florian0410 Awaiting requested review from florian0410 florian0410 is a code owner automatically assigned from cloudposse/contributors

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
do not merge Do not merge this PR, doing so would cause problems
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bengaywins @hans-d @joe-niland