Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix splat #4

Merged
merged 3 commits into from
Jan 12, 2019
Merged

Fix splat #4

merged 3 commits into from
Jan 12, 2019

Conversation

osterman
Copy link
Member

@osterman osterman commented Jan 12, 2019 •
edited
Loading

what

  • Fix splat
  • Remove unused var
  • Parameterize constants
  • Configurable KMS Key ID
  • Add use-case

why

  • Splat required when using count
  • the KMS key previously would only work with cloudposse-style resource IDs which is too strict
  • Closes Update README with Use Case #3

@osterman osterman requested review from joshmyers and aknysh January 12, 2019 08:43
@osterman osterman merged commit 4bdc26f into master Jan 12, 2019
@osterman osterman deleted the fix-splat branch January 12, 2019 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aknysh aknysh aknysh approved these changes

@joshmyers joshmyers Awaiting requested review from joshmyers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@osterman @aknysh