Add ssh_{public,private}_key_ssm_path outputs
#5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osterman
requested changes
Feb 18, 2019
There was a problem hiding this comment.
Just one thing... The README.md is generated from the README.yaml. Make all your changes to the README.yaml, then rebuild.
Please rebuild the README.md by running the follow commands:
make init
make readme/deps
make readme
There might be a lot of changes in the README.md as a result. That's okay!
Sorry for the inconvenience!
|
Btw, you should totally join our community slack team! This is another great place to ask questions and get quickly unblocked. |
aknysh
reviewed
Feb 19, 2019
aknysh
reviewed
Feb 19, 2019
|
Oh, nice -- I didn't realize the README is built that way. Done. |
|
@osterman were the changes sufficient? |
|
Oops! Looks like we missed this. Yes looks good. Can you rebase or fix the merge conflicts? |
rsrchboy
force-pushed
the
ssm-path-outputs
branch
from
17d31a4 to
7b51683
Compare
|
@osterman done! |
osterman
approved these changes
Sep 18, 2019
|
/codefresh run test |
aknysh
approved these changes
Sep 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...as these could be construed as useful :)