Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix/missing tags in permission set #18

Merged
merged 1 commit into from
Jun 28, 2021
Merged

fix/missing tags in permission set #18

merged 1 commit into from
Jun 28, 2021

Conversation

apjneeraj
Copy link
Contributor

what

  • Adding tags to permission set resource in module permission-set.

why

  • tags defined in complete example to supply custom tags but it is not set in aws_ssoadmin_permission_set resource which supports this attribute.

references

@apjneeraj apjneeraj requested review from a team as code owners June 28, 2021 23:10
@apjneeraj apjneeraj requested review from adamcrews and SweetOps June 28, 2021 23:10
Gowiem
Gowiem approved these changes Jun 28, 2021
View reviewed changes
Copy link
Member

@Gowiem Gowiem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Gowiem Gowiem merged commit dce1103 into cloudposse:master Jun 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gowiem Gowiem Gowiem approved these changes

@adamcrews adamcrews Awaiting requested review from adamcrews

@SweetOps SweetOps Awaiting requested review from SweetOps

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@apjneeraj @Gowiem