Feature: Allow VPC Endpoints to be Created via vpc-endpoints Submodule #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…C Endpoints in VPC.
…n being used by other CloudPosse modules.
![bridgecrew[bot]](https://avatars.githubusercontent.com/in/52968?s=60&v=4){kind=small}
korenyoni
requested review from
dotCipher and
woz5999
and removed request for
a team
|
/test all |
|
/test all |
…e Terraform version being used in automated testing (Terraform 0.13).
…on aws_vpc data source.
|
/test all |
|
/test all |
korenyoni
force-pushed
the
feat/vpc-endpoints
branch
from
91236a3 to
bd8ec36
Compare
|
/rebuild-readme |
aknysh
reviewed
Apr 29, 2021
aknysh
reviewed
Apr 29, 2021
aknysh
reviewed
Apr 29, 2021
aknysh
reviewed
Apr 29, 2021
aknysh
reviewed
Apr 29, 2021
aknysh
reviewed
Apr 29, 2021
aknysh
reviewed
Apr 29, 2021
aknysh
previously requested changes
Apr 29, 2021
There was a problem hiding this comment.
@korenyoni
LGTM, a few more comment.
Alps please terraform fmt of all code, examples, and the code in README
…resources, for when local.enabled is false but var.gateway_vpc_endpoints/var.interface_vpc_endpoints is provided.
…aws-vpc into feat/vpc-endpoints
mergify
bot
dismissed
aknysh’s stale review
This Pull Request has been updated, so we're dismissing all reviews.
|
/test all |
aknysh
reviewed
Apr 30, 2021
…gateway/interface VPC endpoints with the endpoint-service name passed as an attribute.
|
/test all |
aknysh
approved these changes
Apr 30, 2021
This was referenced Apr 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
vpc-endpointssubmodule to this repo, which allows users to provision Interface and/or Gateway VPC Endpoints to the VPC they have created with theterraform-aws-vpcmodule.vpc-endpointssubmoduleus-east-2region instead ofus-west-1, as going forward CloudPosse repositories will be usingus-east-2why
terraform-aws-vpcmodule (i.e. subnet IDs), so an external module is required, but a standalone module is not necessarily justified.references