Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Restore Flashbar fixes with workaround for postcss-calc issue #790

Merged
merged 2 commits into from
Feb 28, 2023

Conversation

jperals
Copy link
Member

@jperals jperals commented Feb 27, 2023

Description

Due to some package consumers using an old version of postcss-calc which suffers from a parsing bug, #775 had to be reverted in #787 until a workaround was found. This PR reverts the revert and applies a workaround.

If we can arrive at the point where none of our consumers are affected by that issue, we can revert the second commit in this PR.

How has this been tested?

  • I ran npm run quick-build and then ran postcss-calc 7.0.1 against the file lib/components/flashbar/styles.scoped.css. It crashed before the changes in this PR and succeeded with the changes applied.
  • Visual regression tests for Flashbar fail as expected with the diffs being exactly the same as in fix: Stacked notifications in compact mode and without content padding #775
  • Manually tested the page /app-layout/with-stacked-notifications-and-table. Comprehensive visual regression tests using this page can be introduced once this is merged
Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link

codecov bot commented Feb 27, 2023

Codecov Report

Base: 93.30% // Head: 93.30% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (d0d21cd) compared to base (40f40f5).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #790   +/-   ##
=======================================
  Coverage   93.30%   93.30%           
=======================================
  Files         585      585           
  Lines       17135    17141    +6     
  Branches     4726     4732    +6     
=======================================
+ Hits        15988    15994    +6     
  Misses       1067     1067           
  Partials       80       80           
Impacted Files Coverage Δ
src/app-layout/index.tsx 95.06% <ø> (ø)
src/app-layout/visual-refresh/notifications.tsx 100.00% <ø> (ø)
src/app-layout/notifications/index.tsx 100.00% <100.00%> (ø)
src/flashbar/collapsible-flashbar.tsx 97.95% <100.00%> (+0.05%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jperals jperals marked this pull request as ready for review February 27, 2023 09:17
@jperals jperals requested a review from a team as a code owner February 27, 2023 09:17
@jperals jperals requested review from Al-Dani and removed request for a team February 27, 2023 09:17
@jperals jperals merged commit b3f260b into main Feb 28, 2023
@jperals jperals deleted the workaround/postcss-calc branch February 28, 2023 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants