fix: Restore Flashbar fixes with workaround for postcss-calc issue #790
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Due to some package consumers using an old version of postcss-calc which suffers from a parsing bug, #775 had to be reverted in #787 until a workaround was found. This PR reverts the revert and applies a workaround.
If we can arrive at the point where none of our consumers are affected by that issue, we can revert the second commit in this PR.
How has this been tested?
npm run quick-build
and then ran postcss-calc 7.0.1 against the filelib/components/flashbar/styles.scoped.css
. It crashed before the changes in this PR and succeeded with the changes applied./app-layout/with-stacked-notifications-and-table
. Comprehensive visual regression tests using this page can be introduced once this is mergedReview checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md
.CONTRIBUTING.md
.Security
checkSafeUrl
function.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.