Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Proposal: add channel signal judge to allow onShutdownHook to complete or timeout #250

Closed
li-jin-gou opened this issue Sep 16, 2022 · 0 comments · Fixed by #249
Closed

✨ Proposal: add channel signal judge to allow onShutdownHook to complete or timeout #250

li-jin-gou opened this issue Sep 16, 2022 · 0 comments · Fixed by #249
Assignees
@li-jin-gou
Labels
enhancement New feature or request

Comments

@li-jin-gou
Copy link
Member

li-jin-gou commented Sep 16, 2022 •
edited
Loading

Is your feature request related to a problem? Please describe.

  • When using engin.Shutdown often happens that OnShutdown does not finish executing, because Trigger OnShutdown hooks concurrently, but don't wait them
  • hope to trigger OnShutdown hooks concurrently and wait them until wait timeout or finish

Describe the solution you'd like

  • use channel signal and context.Context to wait OnShutdown until wait timeout or finish
@li-jin-gou li-jin-gou added the enhancement New feature or request label Sep 16, 2022
@li-jin-gou li-jin-gou linked a pull request Sep 16, 2022 that will close this issue
fix: add channel signal judge to allow onShutdownHook to complete or timeout #249
Merged
2 tasks
@li-jin-gou li-jin-gou self-assigned this Sep 17, 2022
@li-jin-gou li-jin-gou changed the title ✨ Proposal: adjust the timing of onShutdownHook execution to allow onShutdownHook to complete ✨ Proposal: add channel signal judge to allow onShutdownHook to complete or timeout Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@li-jin-gou li-jin-gou

Labels
enhancement New feature or request
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: add channel signal judge to allow onShutdownHook to complete or timeout
1 participant
@li-jin-gou