Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add channel signal judge to allow onShutdownHook to complete or timeout #249

Merged
merged 1 commit into from
Sep 19, 2022
Merged

fix: add channel signal judge to allow onShutdownHook to complete or timeout #249

merged 1 commit into from
Sep 19, 2022

Conversation

li-jin-gou
Copy link
Member

@li-jin-gou li-jin-gou commented Sep 16, 2022

What type of PR is this?

  • fix

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.

(Optional) More detail description for this PR(en: English/zh: Chinese).

  • en: add channel signal judge to allow onShutdownHook to complete or timeout
  • zh(optional): 添加channel信号判断,允许 onShutdownHook 执行完成或超时

Which issue(s) this PR fixes:

@li-jin-gou li-jin-gou changed the title reactor: Adjust the timing of shutdown execution to allow onShutdownHook to complete reactor: adjust the timing of shutdown execution to allow onShutdownHook to complete Sep 16, 2022
@li-jin-gou li-jin-gou changed the title reactor: adjust the timing of shutdown execution to allow onShutdownHook to complete reactor: adjust the timing of onShutdownHook execution to allow onShutdownHook to complete Sep 16, 2022
@codecov
Copy link

codecov bot commented Sep 16, 2022

Codecov Report

Base: 59.17% // Head: 59.00% // Decreases project coverage by -0.17% ⚠️

Coverage data is based on head (286d05c) compared to base (97bb37e).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #249      +/-   ##
===========================================
- Coverage    59.17%   59.00%   -0.18%     
===========================================
  Files           79       79              
  Lines         8111     8125      +14     
===========================================
- Hits          4800     4794       -6     
- Misses        2957     2977      +20     
  Partials       354      354              
Impacted Files Coverage Δ
pkg/route/engine.go 61.98% <0.00%> (-2.53%) ⬇️
pkg/common/compress/compress.go 80.95% <0.00%> (-2.86%) ⬇️
pkg/app/client/client.go 71.42% <0.00%> (-0.80%) ⬇️
pkg/route/tree.go 96.67% <0.00%> (+0.01%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

pkg/route/engine.go Outdated Show resolved Hide resolved
Duslia
Duslia previously approved these changes Sep 18, 2022
@li-jin-gou li-jin-gou changed the title reactor: adjust the timing of onShutdownHook execution to allow onShutdownHook to complete 👔 reactor: adjust the timing of onShutdownHook execution to allow onShutdownHook to complete Sep 18, 2022
@welkeyever welkeyever changed the title 👔 reactor: adjust the timing of onShutdownHook execution to allow onShutdownHook to complete reactor: adjust the timing of onShutdownHook execution to allow onShutdownHook to complete Sep 19, 2022
@welkeyever
Copy link
Member

coverage.txt 这个去掉吧..

@li-jin-gou
Copy link
Member Author

coverage.txt 这个去掉吧..
done

pkg/route/engine.go Outdated Show resolved Hide resolved
@li-jin-gou li-jin-gou changed the title reactor: adjust the timing of onShutdownHook execution to allow onShutdownHook to complete reactor: add channel signal judge to allow onShutdownHook to complete or timeout Sep 19, 2022
@li-jin-gou li-jin-gou requested a review from FGYFFFF September 19, 2022 06:28
@welkeyever welkeyever changed the title reactor: add channel signal judge to allow onShutdownHook to complete or timeout fix: add channel signal judge to allow onShutdownHook to complete or timeout Sep 19, 2022
Copy link
Member

@welkeyever welkeyever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@li-jin-gou li-jin-gou merged commit dd2cc8d into cloudwego:develop Sep 19, 2022
@li-jin-gou li-jin-gou deleted the refactor/shutdown branch September 25, 2022 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

✨ Proposal: add channel signal judge to allow onShutdownHook to complete or timeout
4 participants