Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(test): modify the comparison to function signatures in TestClientOptions #1163

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

lhpqaq
Copy link
Contributor

@lhpqaq lhpqaq commented Jul 27, 2024

What type of PR is this?

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

TestClientOptions中的比较函数改为比较函数签名

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
zh(optional):
#1162

(Optional) Which issue(s) this PR fixes:

Fixes #1162

(Optional) The PR that updates user documentation:

@lhpqaq lhpqaq requested review from a team as code owners July 27, 2024 18:43
@CLAassistant
Copy link

CLAassistant commented Jul 27, 2024

CLA assistant check
All committers have signed the CLA.

@lhpqaq lhpqaq changed the title fix(text): modify the comparison to function signatures in TestClientOptions fix(test): modify the comparison to function signatures in TestClientOptions Jul 28, 2024
@lhpqaq
Copy link
Contributor Author

lhpqaq commented Jul 28, 2024

#1162 (comment)

@lhpqaq lhpqaq force-pushed the test branch 2 times, most recently from 833959f to f93263f Compare July 28, 2024 11:02
@Duslia
Copy link
Member

Duslia commented Jul 29, 2024

这个测试设计的不合理,func 类型的单测应该比较函数功能是否相同,比较地址或者函数的类型都是不合理的。已经在#1158 这个 PR 中删掉

@lhpqaq lhpqaq reopened this Jul 29, 2024
@lhpqaq
Copy link
Contributor Author

lhpqaq commented Jul 29, 2024

这个测试设计的不合理,func 类型的单测应该比较函数功能是否相同,比较地址或者函数的类型都是不合理的。已经在#1158 这个 PR 中删掉

比较一下返回值有必要吗

@Duslia
Copy link
Member

Duslia commented Jul 31, 2024

这返回值是个函数呀,要比较的话,得把这个函数运行起来比较函数的功能而不能只比较函数。

@lhpqaq
Copy link
Contributor Author

lhpqaq commented Jul 31, 2024

这返回值是个函数呀,要比较的话,得把这个函数运行起来比较函数的功能而不能只比较函数。

是的,就是比较的返回的这个函数的执行返回值

@GuangmingLuo GuangmingLuo merged commit 9536ec4 into cloudwego:develop Aug 1, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

TestClientOptions 中DeepEqual(DelayPolicyFunc)是比较什么
4 participants