Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: translate Chinese comments to English #150

Merged
merged 1 commit into from
Jul 25, 2022

Conversation

FGYFFFF
Copy link
Contributor

@FGYFFFF FGYFFFF commented Jul 22, 2022

What type of PR is this?

style

What this PR does / why we need it (English/Chinese):

en: translate Chinese comments to English
zh: 将中文注释翻译为英文

Which issue(s) this PR fixes:

@FGYFFFF
Copy link
Contributor Author

FGYFFFF commented Jul 22, 2022

image

无中文了

GuangmingLuo
GuangmingLuo previously approved these changes Jul 22, 2022
Duslia
Duslia previously approved these changes Jul 23, 2022
@FGYFFFF FGYFFFF dismissed stale reviews from Duslia and GuangmingLuo via d4a63c8 July 25, 2022 07:49
@FGYFFFF FGYFFFF force-pushed the style/translate_Chinese branch from 9f617d9 to d4a63c8 Compare July 25, 2022 07:49
Copy link
Member

@welkeyever welkeyever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@FGYFFFF FGYFFFF merged commit a6d2078 into cloudwego:develop Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants