Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: get dialer name #198

Merged
merged 5 commits into from
Sep 20, 2022
Merged

feat: get dialer name #198

merged 5 commits into from
Sep 20, 2022

Conversation

FGYFFFF
Copy link
Contributor

@FGYFFFF FGYFFFF commented Aug 15, 2022

What type of PR is this?

feat

What this PR does / why we need it (English/Chinese):

en: Add the function to get the dialer name
zh: 添加获取 dialer 名的方法

Which issue(s) this PR fixes:

@codecov
Copy link

codecov bot commented Aug 15, 2022

Codecov Report

Base: 59.18% // Head: 59.08% // Decreases project coverage by -0.09% ⚠️

Coverage data is based on head (be567fb) compared to base (0bebcc5).
Patch coverage: 35.29% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #198      +/-   ##
===========================================
- Coverage    59.18%   59.08%   -0.10%     
===========================================
  Files           79       79              
  Lines         8114     8144      +30     
===========================================
+ Hits          4802     4812      +10     
- Misses        2958     2977      +19     
- Partials       354      355       +1     
Impacted Files Coverage Δ
pkg/route/engine.go 61.98% <0.00%> (-2.38%) ⬇️
pkg/app/client/client.go 74.02% <85.71%> (+2.59%) ⬆️
pkg/common/timer/timer.go 61.90% <0.00%> (-19.05%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Duslia
Duslia previously approved these changes Aug 17, 2022
Duslia
Duslia previously approved these changes Sep 19, 2022
welkeyever
welkeyever previously approved these changes Sep 19, 2022
Copy link
Member

@welkeyever welkeyever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@FGYFFFF FGYFFFF dismissed stale reviews from welkeyever and Duslia via b730993 September 20, 2022 02:33
@FGYFFFF FGYFFFF merged commit 0b0c998 into cloudwego:develop Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants