Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: errors support format #258

Merged
merged 1 commit into from
Sep 21, 2022
Merged

feat: errors support format #258

merged 1 commit into from
Sep 21, 2022

Conversation

BaiZe1998
Copy link
Contributor

@BaiZe1998 BaiZe1998 commented Sep 20, 2022

What type of PR is this?

feat

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.

Translate the PR title into Chinese.

支持error的格式化

More detail description for this PR(en: English/zh: Chinese).

en: Add three methods: errors.Newf, errors.NewPublicf, errors.NewPrivatef whit unit tests.

zh: 添加了三个方法:errors.Newferrors.NewPublicferrors.NewPrivatef,并补充了单元测试。

Which issue(s) this PR fixes:

Fixes #248

@codecov
Copy link

codecov bot commented Sep 20, 2022

Codecov Report

Base: 59.18% // Head: 59.17% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (829adb0) compared to base (0bebcc5).
Patch coverage: 23.07% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #258      +/-   ##
===========================================
- Coverage    59.18%   59.17%   -0.01%     
===========================================
  Files           79       79              
  Lines         8114     8150      +36     
===========================================
+ Hits          4802     4823      +21     
- Misses        2958     2972      +14     
- Partials       354      355       +1     
Impacted Files Coverage Δ
pkg/route/engine.go 61.98% <0.00%> (-2.38%) ⬇️
pkg/common/errors/errors.go 87.95% <100.00%> (+7.43%) ⬆️
pkg/common/timer/timer.go 61.90% <0.00%> (-19.05%) ⬇️
pkg/app/client/client.go 74.02% <0.00%> (+2.59%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@li-jin-gou
Copy link
Member

@BaiZe1998 Hello, need to fix ci.

feat: errors support format
@welkeyever welkeyever merged commit ea2569a into cloudwego:develop Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

✨ feat-request: errors support format
3 participants