Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add closeNoResetBuffer method for standard network #265

Merged
merged 1 commit into from
Sep 26, 2022

Conversation

Duslia
Copy link
Member

@Duslia Duslia commented Sep 21, 2022

What type of PR is this?

feat

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.

(Optional) Translate the PR title into Chinese.

在标准库上添加 CloseNoResetBuffer 方法

(Optional) More detail description for this PR(en: English/zh: Chinese).

en: add closeNoResetBuffer method for standard network
zh: 在标准库上添加 CloseNoResetBuffer 方法\

@codecov
Copy link

codecov bot commented Sep 21, 2022

Codecov Report

Base: 59.17% // Head: 59.23% // Increases project coverage by +0.05% 🎉

Coverage data is based on head (d479bf5) compared to base (ea2569a).
Patch coverage: 0.00% of modified lines in pull request are covered.

❗ Current head d479bf5 differs from pull request most recent head 49e9f09. Consider uploading reports for the commit 49e9f09 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #265      +/-   ##
===========================================
+ Coverage    59.17%   59.23%   +0.05%     
===========================================
  Files           79       79              
  Lines         8150     8149       -1     
===========================================
+ Hits          4823     4827       +4     
+ Misses        2972     2967       -5     
  Partials       355      355              
Impacted Files Coverage Δ
pkg/network/standard/connection.go 67.32% <0.00%> (-0.45%) ⬇️
pkg/protocol/header.go 55.95% <ø> (+0.22%) ⬆️
pkg/common/timer/timer.go 80.95% <0.00%> (+19.04%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Duslia Duslia force-pushed the feat/add_closeNoResetBuffer branch from d479bf5 to 49e9f09 Compare September 26, 2022 13:00
@welkeyever welkeyever merged commit f4db636 into develop Sep 26, 2022
@welkeyever welkeyever deleted the feat/add_closeNoResetBuffer branch September 26, 2022 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants