feat(hz): add plugin flag #315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FGYFFFF
force-pushed
the
feat/optimize_plugin_flag
branch
from
12ea120 to
6791788
Compare
Codecov ReportBase: 66.10% // Head: 66.10% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## develop #315 +/- ##
========================================
Coverage 66.10% 66.10%
========================================
Files 85 85
Lines 8317 8317
========================================
Hits 5498 5498
Misses 2459 2459
Partials 360 360 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
welkeyever
reviewed
Oct 21, 2022
Duslia
previously approved these changes
Oct 21, 2022
|
"urfave/cli" 这个仓库在解析多参数的时候会默认以 "," 作为分隔符，导致透传 protoc 参数有一些阻碍；可以写个 hack 逻辑在我们的代码里，但是很不优雅。因此，给他们提了个feature(urfave/cli)，应该很快会合入&发版 |
FGYFFFF
force-pushed
the
feat/optimize_plugin_flag
branch
2 times, most recently
from
8d89710 to
2221cb7
Compare
FGYFFFF
force-pushed
the
feat/optimize_plugin_flag
branch
from
2221cb7 to
fef167c
Compare
FGYFFFF
commented
Nov 1, 2022
welkeyever
approved these changes
Nov 8, 2022
Duslia
approved these changes
Nov 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
feat
Check the PR title.
(Optional) Translate the PR title into Chinese.
添加接入thriftgo/protoc第三方插件的接口
(Optional) More detail description for this PR(en: English/zh: Chinese).
en: add plugin flag
zh(optional): 添加接入thriftgo/protoc第三方插件的接口
Which issue(s) this PR fixes: