Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: zero idle timeout acts the same #357

Conversation

welkeyever
Copy link
Member

What type of PR is this?

optimize

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.

(Optional) Translate the PR title into Chinese.

设置 idle timeout 为 0 在不同的网络库下行为一致

(Optional) More detail description for this PR(en: English/zh: Chinese).

en: before this, standard network cannot process requests properly when idle timeout is set to zero, this may be confusing to users.
zh(optional): 在此之前,标准网络在空闲超时设置为零时无法正确处理请求,这可能会让用户感到困惑。

Which issue(s) this PR fixes:

None

@codecov
Copy link

codecov bot commented Nov 9, 2022

Codecov Report

Base: 66.54% // Head: 66.50% // Decreases project coverage by -0.03% ⚠️

Coverage data is based on head (6be28d4) compared to base (c89d7ac).
Patch coverage: 66.66% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #357      +/-   ##
===========================================
- Coverage    66.54%   66.50%   -0.04%     
===========================================
  Files           89       89              
  Lines         8507     8512       +5     
===========================================
  Hits          5661     5661              
- Misses        2484     2489       +5     
  Partials       362      362              
Impacted Files Coverage Δ
pkg/common/test/mock/network.go 0.00% <0.00%> (ø)
pkg/protocol/http1/server.go 0.00% <ø> (ø)
pkg/route/engine.go 62.88% <100.00%> (+0.24%) ⬆️
pkg/common/compress/compress.go 80.95% <0.00%> (-2.86%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@welkeyever welkeyever force-pushed the optimize/same_idle_timeout_work_for_both branch from c71b136 to 6be28d4 Compare November 10, 2022 07:43
@welkeyever welkeyever merged commit 2a97f9b into cloudwego:develop Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants