Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adapt the logic after moving the http2 logic to hertz-contrib #418

Merged
merged 1 commit into from
Nov 29, 2022

Conversation

Duslia
Copy link
Member

@Duslia Duslia commented Nov 25, 2022

What type of PR is this?

feat

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.

(Optional) Translate the PR title into Chinese.

适配将 http2 逻辑挪到 hertz-contrib 后的逻辑

(Optional) More detail description for this PR(en: English/zh: Chinese).

en: Adapt the logic after moving the http2 logic to hertz-contrib
zh(optional): 适配将 http2 逻辑挪到 hertz-contrib 后的逻辑

Which issue(s) this PR fixes:

@codecov
Copy link

codecov bot commented Nov 25, 2022

Codecov Report

Base: 67.53% // Head: 68.13% // Increases project coverage by +0.60% 🎉

Coverage data is based on head (2def49c) compared to base (d601515).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #418      +/-   ##
===========================================
+ Coverage    67.53%   68.13%   +0.60%     
===========================================
  Files           89       90       +1     
  Lines         8608     8627      +19     
===========================================
+ Hits          5813     5878      +65     
+ Misses        2435     2388      -47     
- Partials       360      361       +1     
Impacted Files Coverage Δ
pkg/route/engine.go 62.69% <ø> (-0.20%) ⬇️
pkg/app/client/discovery/discovery.go 100.00% <0.00%> (ø)
pkg/protocol/header.go 74.25% <0.00%> (+0.26%) ⬆️
pkg/protocol/response.go 81.08% <0.00%> (+20.94%) ⬆️
...kg/app/middlewares/server/basic_auth/basic_auth.go 100.00% <0.00%> (+54.54%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@li-jin-gou li-jin-gou merged commit f4b9e2b into develop Nov 29, 2022
@Duslia Duslia deleted the feat/http2_adapt branch December 28, 2022 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants