chore(codegen): use ::std::default::Default in struct's codegen (#295) #815
clippy
33 warnings
Details
Results
Message level | Amount |
---|---|
Internal compiler error | 0 |
Error | 0 |
Warning | 33 |
Note | 0 |
Help | 0 |
Versions
- rustc 1.85.0-nightly (4363f9b6f 2025-01-02)
- cargo 1.85.0-nightly (d73d2caf9 2024-12-31)
- clippy 0.1.85 (4363f9b6f6 2025-01-02)
Annotations
Check warning on line 1 in examples/src/lib.rs
github-actions / clippy
unused import: `pilota::prost::Message as _`
warning: unused import: `pilota::prost::Message as _`
--> examples/src/lib.rs:1:5
|
1 | use pilota::prost::Message as _;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: `#[warn(unused_imports)]` on by default
Check warning on line 328 in pilota-build/src/middle/context.rs
github-actions / clippy
this function has too many arguments (8/7)
warning: this function has too many arguments (8/7)
--> pilota-build/src/middle/context.rs:319:5
|
319 | / pub(crate) fn build(
320 | | self,
321 | | services: Arc<[crate::IdlService]>,
322 | | source_type: SourceType,
... |
327 | | split: bool,
328 | | ) -> Context {
| |________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
= note: `#[warn(clippy::too_many_arguments)]` on by default
Check warning on line 26 in pilota-build/src/codegen/pkg_tree.rs
github-actions / clippy
unnecessary use of `first().is_some()` to check if slice is not empty
warning: unnecessary use of `first().is_some()` to check if slice is not empty
--> pilota-build/src/codegen/pkg_tree.rs:26:21
|
26 | .filter(|p| p.first().is_some())
| ^^^^^^^^^^^^^^^^^^^ help: replace this with: `!p.is_empty()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_first_then_check
Check warning on line 17 in pilota-build/src/codegen/pkg_tree.rs
github-actions / clippy
unnecessary use of `first().is_some()` to check if slice is not empty
warning: unnecessary use of `first().is_some()` to check if slice is not empty
--> pilota-build/src/codegen/pkg_tree.rs:17:31
|
17 | if pkgs.iter().filter(|p| p.first().is_some()).count() == 0 {
| ^^^^^^^^^^^^^^^^^^^ help: replace this with: `!p.is_empty()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_first_then_check
= note: `#[warn(clippy::unnecessary_first_then_check)]` on by default
Check warning on line 60 in pilota-build/src/ir/mod.rs
github-actions / clippy
struct `ExceptionVariant` is never constructed
warning: struct `ExceptionVariant` is never constructed
--> pilota-build/src/ir/mod.rs:60:12
|
60 | pub struct ExceptionVariant {
| ^^^^^^^^^^^^^^^^
|
= note: `ExceptionVariant` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis
Check warning on line 14 in pilota-build/src/index.rs
github-actions / clippy
method `increment_by` is never used
warning: method `increment_by` is never used
--> pilota-build/src/index.rs:14:8
|
3 | pub trait Idx: Sized + Copy + 'static {
| --- method in this trait
...
14 | fn increment_by(&mut self, amount: usize) {
| ^^^^^^^^^^^^
|
= note: `#[warn(dead_code)]` on by default
Check warning on line 907 in pilota/src/thrift/binary_unsafe.rs
github-actions / clippy
the following explicit lifetimes could be elided: 'a
warning: the following explicit lifetimes could be elided: 'a
--> pilota/src/thrift/binary_unsafe.rs:907:6
|
907 | impl<'a> TInputProtocol for TBinaryUnsafeInputProtocol<'a> {
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
907 - impl<'a> TInputProtocol for TBinaryUnsafeInputProtocol<'a> {
907 + impl TInputProtocol for TBinaryUnsafeInputProtocol<'_> {
|
Check warning on line 766 in pilota/src/thrift/binary_unsafe.rs
github-actions / clippy
the following explicit lifetimes could be elided: 'a
warning: the following explicit lifetimes could be elided: 'a
--> pilota/src/thrift/binary_unsafe.rs:766:6
|
766 | impl<'a> TLengthProtocol for TBinaryUnsafeInputProtocol<'a> {
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
766 - impl<'a> TLengthProtocol for TBinaryUnsafeInputProtocol<'a> {
766 + impl TLengthProtocol for TBinaryUnsafeInputProtocol<'_> {
|
Check warning on line 67 in pilota/src/prost/mod.rs
github-actions / clippy
usage of a legacy numeric method
warning: usage of a legacy numeric method
--> pilota/src/prost/mod.rs:67:24
|
67 | if length > usize::max_value() as u64 {
| ^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants
help: use the associated constant instead
|
67 | if length > usize::MAX as u64 {
| ~~~
Check warning on line 955 in pilota/src/prost/encoding.rs
github-actions / clippy
the following explicit lifetimes could be elided: 'a
warning: the following explicit lifetimes could be elided: 'a
--> pilota/src/prost/encoding.rs:955:18
|
955 | impl<'a> Drop for DropGuard<'a> {
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
= note: `#[warn(clippy::needless_lifetimes)]` on by default
help: elide the lifetimes
|
955 - impl<'a> Drop for DropGuard<'a> {
955 + impl Drop for DropGuard<'_> {
|
Check warning on line 9 in pilota/src/prost/encoding.rs
github-actions / clippy
importing legacy numeric constants
warning: importing legacy numeric constants
--> pilota/src/prost/encoding.rs:9:55
|
9 | use core::{cmp::min, convert::TryFrom, mem, str, u32, usize};
| ^^^^^
|
= help: remove this import
= note: then `usize::<CONST>` will resolve to the respective associated constant
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants
Check warning on line 9 in pilota/src/prost/encoding.rs
github-actions / clippy
importing legacy numeric constants
warning: importing legacy numeric constants
--> pilota/src/prost/encoding.rs:9:50
|
9 | use core::{cmp::min, convert::TryFrom, mem, str, u32, usize};
| ^^^
|
= help: remove this import
= note: then `u32::<CONST>` will resolve to the respective associated constant
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants
Check warning on line 4 in pilota/src/prost/message.rs
github-actions / clippy
importing legacy numeric constants
warning: importing legacy numeric constants
--> pilota/src/prost/message.rs:4:24
|
4 | use core::{fmt::Debug, usize};
| ^^^^^
|
= help: remove this import
= note: then `usize::<CONST>` will resolve to the respective associated constant
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants
= note: `#[warn(clippy::legacy_numeric_constants)]` on by default
Check warning on line 1661 in pilota/src/prost/encoding.rs
github-actions / clippy
value assigned to `skip_default_value` is never read
warning: value assigned to `skip_default_value` is never read
--> pilota/src/prost/encoding.rs:1661:21
|
1661 | let mut skip_default_value = true;
| ^^^^^^^^^^^^^^^^^^
...
1693 | map!(BTreeMap);
| -------------- in this macro invocation
|
= help: maybe it is overwritten before being read?
= note: this warning originates in the macro `map` (in Nightly builds, run with -Z macro-backtrace for more info)
Check warning on line 1583 in pilota/src/prost/encoding.rs
github-actions / clippy
value assigned to `skip_val` is never read
warning: value assigned to `skip_val` is never read
--> pilota/src/prost/encoding.rs:1583:25
|
1583 | let mut skip_val = val == val_default;
| ^^^^^^^^
...
1693 | map!(BTreeMap);
| -------------- in this macro invocation
|
= help: maybe it is overwritten before being read?
= note: this warning originates in the macro `map` (in Nightly builds, run with -Z macro-backtrace for more info)
Check warning on line 1582 in pilota/src/prost/encoding.rs
github-actions / clippy
value assigned to `skip_key` is never read
warning: value assigned to `skip_key` is never read
--> pilota/src/prost/encoding.rs:1582:25
|
1582 | let mut skip_key = key == &K::default();
| ^^^^^^^^
...
1693 | map!(BTreeMap);
| -------------- in this macro invocation
|
= help: maybe it is overwritten before being read?
= note: this warning originates in the macro `map` (in Nightly builds, run with -Z macro-backtrace for more info)
Check warning on line 1661 in pilota/src/prost/encoding.rs
github-actions / clippy
value assigned to `skip_default_value` is never read
warning: value assigned to `skip_default_value` is never read
--> pilota/src/prost/encoding.rs:1661:21
|
1661 | let mut skip_default_value = true;
| ^^^^^^^^^^^^^^^^^^
...
1689 | map!(AHashMap);
| -------------- in this macro invocation
|
= help: maybe it is overwritten before being read?
= note: this warning originates in the macro `map` (in Nightly builds, run with -Z macro-backtrace for more info)
Check warning on line 1583 in pilota/src/prost/encoding.rs
github-actions / clippy
value assigned to `skip_val` is never read
warning: value assigned to `skip_val` is never read
--> pilota/src/prost/encoding.rs:1583:25
|
1583 | let mut skip_val = val == val_default;
| ^^^^^^^^
...
1689 | map!(AHashMap);
| -------------- in this macro invocation
|
= help: maybe it is overwritten before being read?
= note: this warning originates in the macro `map` (in Nightly builds, run with -Z macro-backtrace for more info)
Check warning on line 1582 in pilota/src/prost/encoding.rs
github-actions / clippy
value assigned to `skip_key` is never read
warning: value assigned to `skip_key` is never read
--> pilota/src/prost/encoding.rs:1582:25
|
1582 | let mut skip_key = key == &K::default();
| ^^^^^^^^
...
1689 | map!(AHashMap);
| -------------- in this macro invocation
|
= help: maybe it is overwritten before being read?
= note: `#[warn(unused_assignments)]` on by default
= note: this warning originates in the macro `map` (in Nightly builds, run with -Z macro-backtrace for more info)
Check warning on line 1496 in pilota/src/thrift/compact.rs
github-actions / clippy
operator precedence can trip the unwary
warning: operator precedence can trip the unwary
--> pilota/src/thrift/compact.rs:1495:21
|
1495 | / (tcompact_get_compact(identifier.key_type).unwrap() as u8) << 4
1496 | | | (tcompact_get_compact(identifier.value_type).unwrap()) as u8,
| |______________________________________________________________________________________^ help: consider parenthesizing your expression: `((tcompact_get_compact(identifier.key_type).unwrap() as u8) << 4) | (tcompact_get_compact(identifier.value_type).unwrap()) as u8`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
Check warning on line 933 in pilota/src/thrift/compact.rs
github-actions / clippy
operator precedence can trip the unwary
warning: operator precedence can trip the unwary
--> pilota/src/thrift/compact.rs:932:17
|
932 | / (tcompact_get_compact(identifier.key_type)? as u8) << 4
933 | | | (tcompact_get_compact(identifier.value_type)?) as u8,
| |__________________________________________________________________________^ help: consider parenthesizing your expression: `((tcompact_get_compact(identifier.key_type)? as u8) << 4) | (tcompact_get_compact(identifier.value_type)?) as u8`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
Check warning on line 648 in pilota/src/thrift/compact.rs
github-actions / clippy
operator precedence can trip the unwary
warning: operator precedence can trip the unwary
--> pilota/src/thrift/compact.rs:647:17
|
647 | / (tcompact_get_compact(identifier.key_type)? as u8) << 4
648 | | | (tcompact_get_compact(identifier.value_type)?) as u8,
| |__________________________________________________________________________^ help: consider parenthesizing your expression: `((tcompact_get_compact(identifier.key_type)? as u8) << 4) | (tcompact_get_compact(identifier.value_type)?) as u8`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
Check warning on line 378 in pilota/src/thrift/compact.rs
github-actions / clippy
operator precedence can trip the unwary
warning: operator precedence can trip the unwary
--> pilota/src/thrift/compact.rs:377:21
|
377 | / (tcompact_get_compact(identifier.key_type).unwrap() as u8) << 4
378 | | | (tcompact_get_compact(identifier.value_type).unwrap()) as u8,
| |______________________________________________________________________________________^ help: consider parenthesizing your expression: `((tcompact_get_compact(identifier.key_type).unwrap() as u8) << 4) | (tcompact_get_compact(identifier.value_type).unwrap()) as u8`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
= note: `#[warn(clippy::precedence)]` on by default
Check warning on line 246 in pilota/src/prost/encoding.rs
github-actions / clippy
unexpected `cfg` condition value: `no-recursion-limit`
warning: unexpected `cfg` condition value: `no-recursion-limit`
--> pilota/src/prost/encoding.rs:246:11
|
246 | #[cfg(feature = "no-recursion-limit")]
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: expected values for `feature` are: `pb-encode-default-value` and `unstable`
= help: consider adding `no-recursion-limit` as a feature in `Cargo.toml`
= note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration
Check warning on line 236 in pilota/src/prost/encoding.rs
github-actions / clippy
unexpected `cfg` condition value: `no-recursion-limit`
warning: unexpected `cfg` condition value: `no-recursion-limit`
--> pilota/src/prost/encoding.rs:236:15
|
236 | #[cfg(not(feature = "no-recursion-limit"))]
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: expected values for `feature` are: `pb-encode-default-value` and `unstable`
= help: consider adding `no-recursion-limit` as a feature in `Cargo.toml`
= note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration