-
Notifications
You must be signed in to change notification settings - Fork 510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
merge updates to resizablelib from https://github.com/ppescher/resizablelib #2885
Conversation
The The custom code can be marked with this comment to easily find it in future when merging updates: |
Yes, he merged similar code after I reported the issue. |
You can leave this open for now. I'm going to see which patches I can get accepted before merging changes to mpc-hc. |
The thing is that the maintainer said he'll look into the changes here and might integrate some, so some comments might become redundant shortly. This might be a non issue, but I just thought I might bring this up, just in case. |
Once we agree on what changes make sense to merge, we may not need the comments at all. But if we do need them, I'll see if it's possible to derive a class rather than changing the resizelib code. This allows us to make it a linked project if we want, but even if not, merging is easier. |
This latest commit is supposed to fix redraw issues that were covered up by an extra Perhaps the ncpaint is supposed to exclude the triangular gripper, but I failed to get it working. |
Let me know when this is ready to merge. |
We can merge it. I haven't heard anything about my latest commits. But I will revisit in the future. |
I'm sorry guys, I only can find a few hours a week to work on my "pet" projects and sometimes not even that. |
No worries, I really appreciate you collaborating with us on this. If it helps, maybe I can make a fork of your project with all the proposed changes and you can merge them back at your leisure, if you like them. |
Try to bring our code as close to the latest as possible, while retaining useful mods.