Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge updates to resizablelib from https://github.com/ppescher/resizablelib #2885

Merged
merged 4 commits into from
Jul 11, 2024

Conversation

adipose
Copy link

@adipose adipose commented Jun 28, 2024

Try to bring our code as close to the latest as possible, while retaining useful mods.

@clsid2
Copy link
Owner

clsid2 commented Jun 28, 2024

The CalcSizeExtra function is no longer needed with updated code? Just checking.

The custom code can be marked with this comment to easily find it in future when merging updates:
// MPC-HC custom

@adipose
Copy link
Author

adipose commented Jun 28, 2024

The CalcSizeExtra function is no longer needed with updated code? Just checking.

The custom code can be marked with this comment to easily find it in future when merging updates:

// MPC-HC custom

Yes, he merged similar code after I reported the issue.

@adipose
Copy link
Author

adipose commented Jun 28, 2024

You can leave this open for now. I'm going to see which patches I can get accepted before merging changes to mpc-hc.

@NBruderman
Copy link

The CalcSizeExtra function is no longer needed with updated code? Just checking.

The custom code can be marked with this comment to easily find it in future when merging updates:
// MPC-HC custom

The thing is that the maintainer said he'll look into the changes here and might integrate some, so some comments might become redundant shortly. This might be a non issue, but I just thought I might bring this up, just in case.

@adipose
Copy link
Author

adipose commented Jun 28, 2024

Once we agree on what changes make sense to merge, we may not need the comments at all. But if we do need them, I'll see if it's possible to derive a class rather than changing the resizelib code. This allows us to make it a linked project if we want, but even if not, merging is easier.

@adipose
Copy link
Author

adipose commented Jul 2, 2024

This latest commit is supposed to fix redraw issues that were covered up by an extra Invalidate() call. The one I found difficult to fix was the gripper. It seems like both windows and resizelib draw a gripper (in the case of a statusbar that has a gripper, that is). I settled on invalidating the gripper itself after a resize.

Perhaps the ncpaint is supposed to exclude the triangular gripper, but I failed to get it working.

@clsid2
Copy link
Owner

clsid2 commented Jul 11, 2024

Let me know when this is ready to merge.

@adipose
Copy link
Author

adipose commented Jul 11, 2024

We can merge it. I haven't heard anything about my latest commits. But I will revisit in the future.

@ppescher

@clsid2 clsid2 merged commit fecd9a0 into clsid2:develop Jul 11, 2024
@ppescher
Copy link

I'm sorry guys, I only can find a few hours a week to work on my "pet" projects and sometimes not even that.
And even worse, sometimes I just forget... guess I'm getting old, or maybe I need a vacation! 😞

@adipose
Copy link
Author

adipose commented Jul 11, 2024

I'm sorry guys, I only can find a few hours a week to work on my "pet" projects and sometimes not even that.
And even worse, sometimes I just forget... guess I'm getting old, or maybe I need a vacation! 😞

No worries, I really appreciate you collaborating with us on this. If it helps, maybe I can make a fork of your project with all the proposed changes and you can merge them back at your leisure, if you like them.

@adipose adipose deleted the patch460 branch July 12, 2024 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants