Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PsGet should probably no longer be a standard module #2841

Closed
2 tasks done
schittli opened this issue Apr 14, 2023 · 3 comments · Fixed by #2851
Closed
2 tasks done

PsGet should probably no longer be a standard module #2841

schittli opened this issue Apr 14, 2023 · 3 comments · Fixed by #2851

Comments

@schittli
Copy link

Question

Good evening

I'm pretty sure, it's no longer wise to have PsGet embedded in Cmder:

  • the PsGet GitHub Project: https://github.com/psget/psget is archived

  • Because PsGet is no longer supported, it no longer gets (security) updates

  • if you open the PsGet Homepage (listed on the archived GitHub Page): psget.net you will wonder about the result:
    image

  • Commands like Get-Help <psget command> -Online opens the 'hijacked' psget.net website

Therefore, I don't think it's wise that Cmder deploys the no longer supported and no longer updated PowerShell module PsGet.

Thanks a lot, kind regards,
Thomas

Checklist

  • I have read the documentation and made sure what I'm looking for isn't present, or is unclear.
  • I have searched for similar issues, and either this question wasn't asked before, or I didn't find any that describe my question.
@DRSDavidSoft
Copy link
Contributor

CC'ing @cmderdev/trusted-contributors and @cmderdev/core

If PsGet is not used by the community, we should definitely remove it.

Otherwise we should remove the link to the taken down domain (as the PsGet module's full code is present in the repo).

@daxgames
Copy link
Member

I'm all for removing it completely.

@MartiUK
Copy link
Member

MartiUK commented May 23, 2023

100% should be removed

MartiUK added a commit to MartiUK/cmder that referenced this issue May 23, 2023
Fixes cmderdev#2841

Signed-off-by: Martin Kemp <[email protected]>
@DRSDavidSoft DRSDavidSoft changed the title Question: PsGet should probably no longer be a standard module PsGet should probably no longer be a standard module May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants