#420 and #577 - use registry for CMDER_START #1372
Conversation
Environment variables don't seem to work properly when cmder starts ConEmu using /single. These changes communicate the intended start path using a registry key.
Or at least I tried...
|
@Stanzilla on the subject of branches, if the |
|
That would certainly be a an option. @cmderdev/trusted-contributors thoughts? |
|
No issues. |
|
Sorry it took me so long. I'd never rebased anything before. I think I did it correctly. |
|
Not quite, but almost, you commited merge conflicts here https://github.com/cmderdev/cmder/pull/1372/files#diff-159626d08a0475178d80ae25e9d36f17R91 and in init.bat |
Missed this when rebasing.
There was a problem hiding this comment.
@superelitist Thanks for the effort but I don't understand the point of this PR since we have now fixed the env var issues. Also to make it all work users should use a nightly build, at least until cmder 1.3.6+ is released, and remove /new_console args from their default start tasks.
This PR should be closed as rejected unless someone can prove it is still required.
|
I agree. Having tested it (under 1.3.5 actually), it seems to be working (almost) as expected (except if it was launched elevated all tasks then run elevated, but that's a completely separate issue - and may be fixed in 1.3.6, but I don't usually run nightly builds). |
Environment variables don't seem to work properly when cmder starts
ConEmu using /single. These changes communicate the intended start path
using a registry key.
Sorry, I didn't make changes from development, but that branch looks pretty out of date.