Messenger Between Scope

[trotsaleksandrov]

Hello!
It appears for me, while trying to use default betweenScope located in Thread model, it doesn't work as expected. For example, Thread::between([1,2]) will return all the Threads where users with ids 1 and 2 are participating. Instead, it should return the only chat with users with these ids. Am i the one who is facing this issue? Can you provide some ideas, how to manage this?
Thanks in advance!

[antonkomarev]

Did you mean that it returns threads where participants are: 1, 2, 3 too?

[trotsaleksandrov]

Exactly

[antonkomarev]

@trotsaleksandrov yeah... I've met such issue and just overrided a logic of getting the threads. You are free to extend Thread model with your own and write you own logic.

Change thread model in config.

I don't know is this planned behavior or not.

[trotsaleksandrov]

That's the problem, that's it's hard to get the threads between exact users. But anyway, thanks for help :)

[antonkomarev]

You can have additional column in threads table where all participants will be stored as string: 1,2,3
On search you can compare participants you want with this string.

The only thing you should to remember - always store ordered ids, because if you will save value as 1,3,2 this trick wouldn't work. And then you will need to have an index on this column.

[antonkomarev]

But anyway @cmgmyr should look at this issue. As for me - current behavior is bugged.

Or maybe there should be one more additional method: betweenOnly. Which will return threads where only provided users are participating.

[trotsaleksandrov]

Cannot but agree with you. It would be great if this functionality would be reviewed

[cmgmyr]

I started to look into this yesterday but wasn't able to get far before I had to get going. I am seeing the same thing on my end and agree that it should be fixed. I'll work on it.

I'm thinking that the current functionality could be useful for some. So maybe the between scope should return the threads only between users 1 and 2 (as intended), but adding something like betweenLoose that would return threads that include users 1 and 2, but also can have other participants (like current functionality). Thoughts?

[trotsaleksandrov]

Maybe it is better to split existing between method to two: as you mentioned, something like betweenLoose and as @a-komarev mentioned betweenOnly. Because retrieving threads that includes users 1 and 2, might also be useful

[antonkomarev]

@cmgmyr To make method betweenLoose was my first thought... but this will be breaking change.

We can add 2 new methods. betweenLoose and betweenOnly. Make method between as an alias for betweenLoose for now and mark it as @deprecated in docblock. In future major release it could be dropped or will be an alias for betweenOnly method. By this way we wouldn't affect already launched applications. Or just make major release :}

[cmgmyr]

@a-komarev yup, that's exactly what I was thinking. I've also been thinking about rewriting the whole package to be a little more user friendly and not just a bunch of models.

[antonkomarev]

@cmgmyr Any ETA of these plans?

[cmgmyr]

@a-komarev the v3 plans? Unfortunately, not yet besides some planning in my head. Started a new job recently, so it's been cutting in on my free time a bit. Hopefully will get some code out soon though

[s1lviu]

For me
$thread = Thread::between([1, 2])->latest('updated_at')->firstOrFail();
returns
No query results for model [Cmgmyr\Messenger\Models\Thread].

[AbdullahFaqeir]

Still need help with this??

[cmgmyr]

@AbdullahFaqeir yes, this still needs to be worked on. I haven't gotten a chance to revisit it yet. Feel free to use the WIP as a starting point or just start fresh 👍

[AbdullahFaqeir]

@cmgmyr working on it now.

[AbdullahFaqeir]

@AbdullahFaqeir yes, this still needs to be worked on. I haven't gotten a chance to revisit it yet. Feel free to use the WIP as a starting point or just start fresh 👍

I've submitted a PR if you can review it.