Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New spec for Py3 pycodestyle; added to wmcorepy3-devtools #7846

Merged
merged 4 commits into from
May 6, 2022

Conversation

amaltaro
Copy link

@amaltaro amaltaro commented May 5, 2022

Create a python3 pycodestyle spec, which has no other dependencies; remove the py3-pep8, which was only used by WMCore; last but not least, update py3-pylint to 2.13.5 and bring in all the necessary updates and new specs that it depends on.

@@ -1,10 +1,10 @@
### RPM cms wmcorepy3-devtools 0.2
### RPM cms wmcorepy3-devtools 0.3

# This is a meta-package to group development tool dependencies
Requires: yuicompressor
Requires: python3 py3-mock py3-pep8 py3-mox3 py3-pylint py3-coverage py3-nose py3-nose2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove py3-pep8 here?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do, thanks!

@muhammadimranfarooqi
Copy link

-1 to ca09068 on slc7_amd64_gcc630.
Build log can be found here.

@amaltaro
Copy link
Author

amaltaro commented May 5, 2022

It fails because this new version of pylint requires many other dependencies:

+ echo 'ERROR: Missing dependencies for py3-pylint (python3) found: py3-dill py3-platformdirs py3-tomli py3-typing-extensions '

@muhammadimranfarooqi
Copy link

-1 to 23a72ec on slc7_amd64_gcc630.
Build log can be found here.

@muhammadimranfarooqi
Copy link

-1 to a7ab4a4 on slc7_amd64_gcc630.
Build log can be found here.

@amaltaro
Copy link
Author

amaltaro commented May 5, 2022

@belforte @mapellidario just a heads up that we are updating some of the python3 library versions. Please see first description for further details.

@muhammadimranfarooqi
Copy link

-1 to 39498d8 on slc7_amd64_gcc630.
Build log can be found here.

@muhammadimranfarooqi
Copy link

-1 to c239a66 on slc7_amd64_gcc630.
Build log can be found here.

@amaltaro amaltaro force-pushed the wmcore-pylint-2135 branch from c239a66 to 348a68d Compare May 6, 2022 00:34
@muhammadimranfarooqi
Copy link

-1 to 348a68d on slc7_amd64_gcc630.
Build log can be found here.

@amaltaro amaltaro force-pushed the wmcore-pylint-2135 branch from 348a68d to 491c7d6 Compare May 6, 2022 01:11
@muhammadimranfarooqi
Copy link

+1 to 491c7d6 on slc7_amd64_gcc630.
Build log can be found here.

@amaltaro
Copy link
Author

amaltaro commented May 6, 2022

merge

@cmsbuild cmsbuild merged commit f4ce0ac into cms-sw:comp_gcc630 May 6, 2022
@cmsbuild
Copy link
Contributor

cmsbuild commented May 6, 2022

Command merge acknowledged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants