Fixed mapstructure annotations + introduced notStateless const

Signed-off-by: Simon Ferquel <[email protected]>

pkg/action/action.go

@@ -13,6 +13,9 @@ import (
 	"github.com/deislabs/duffle/pkg/driver"
 )
 
+// notStateless is there just to make callers of opFromClaims more readable
+const notStateless = false
+
 // Action describes one of the primary actions that can be executed in CNAB.
 //
 // The actions are:

pkg/action/action_test.go

@@ -99,7 +99,7 @@ func TestOpFromClaim(t *testing.T) {
 	}
 	invocImage := c.Bundle.InvocationImages[0]
 
-	op, err := opFromClaim(claim.ActionInstall, false, c, invocImage, mockSet, os.Stdout)
+	op, err := opFromClaim(claim.ActionInstall, notStateless, c, invocImage, mockSet, os.Stdout)
 	if err != nil {
 		t.Fatal(err)
 	}
@@ -140,7 +140,7 @@ func TestOpFromClaim_UndefinedParams(t *testing.T) {
 	}
 	invocImage := c.Bundle.InvocationImages[0]
 
-	_, err := opFromClaim(claim.ActionInstall, false, c, invocImage, mockSet, os.Stdout)
+	_, err := opFromClaim(claim.ActionInstall, notStateless, c, invocImage, mockSet, os.Stdout)
 	assert.Error(t, err)
 }
 

pkg/action/install.go

@@ -20,7 +20,7 @@ func (i *Install) Run(c *claim.Claim, creds credentials.Set, w io.Writer) error
 		return err
 	}
 
-	op, err := opFromClaim(claim.ActionInstall, false, c, invocImage, creds, w)
+	op, err := opFromClaim(claim.ActionInstall, notStateless, c, invocImage, creds, w)
 	if err != nil {
 		return err
 	}

pkg/action/status.go

@@ -20,7 +20,7 @@ func (i *Status) Run(c *claim.Claim, creds credentials.Set, w io.Writer) error {
 		return err
 	}
 
-	op, err := opFromClaim(claim.ActionStatus, false, c, invocImage, creds, w)
+	op, err := opFromClaim(claim.ActionStatus, notStateless, c, invocImage, creds, w)
 	if err != nil {
 		return err
 	}

pkg/action/uninstall.go

@@ -20,7 +20,7 @@ func (u *Uninstall) Run(c *claim.Claim, creds credentials.Set, w io.Writer) erro
 		return err
 	}
 
-	op, err := opFromClaim(claim.ActionUninstall, false, c, invocImage, creds, w)
+	op, err := opFromClaim(claim.ActionUninstall, notStateless, c, invocImage, creds, w)
 	if err != nil {
 		return err
 	}

pkg/action/upgrade.go

@@ -20,7 +20,7 @@ func (u *Upgrade) Run(c *claim.Claim, creds credentials.Set, w io.Writer) error
 		return err
 	}
 
-	op, err := opFromClaim(claim.ActionUpgrade, false, c, invocImage, creds, w)
+	op, err := opFromClaim(claim.ActionUpgrade, notStateless, c, invocImage, creds, w)
 	if err != nil {
 		return err
 	}

pkg/bundle/bundle.go

@@ -116,13 +116,13 @@ type Action struct {
 	// Modifies indicates whether this action modifies the release.
 	//
 	// If it is possible that an action modify a release, this must be set to true.
-	Modifies bool `json:"modifies,omitempty"`
+	Modifies bool `json:"modifies" mapstructure:"modifies"`
 
 	// Stateless indicates that the action is purely informational, that credentials are not required, and that the runtime should not keep track of its invocation
-	Stateless bool `json:"stateless,omitempty"`
+	Stateless bool `json:"stateless" mapstructure:"stateless"`
 
 	// Description describes the action as a user-readable string
-	Description string `json:"description,omitempty"`
+	Description string `json:"description,omitempty" mapstructure:"description,omitempty"`
 }
 
 // ValuesOrDefaults returns parameter values or the default parameter values