This repository has been archived by the owner on May 3, 2022. It is now read-only.
feat: add signature library #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, add a passphrase fetcher to the keyring, and have that fetcher passed to every key.
technosophos
force-pushed
the
feat/signing
branch
from
e36001d to
3a5327e
Compare
vdice
approved these changes
Oct 2, 2018
pkg/signature/keys.go
Outdated
| "golang.org/x/crypto/openpgp/packet" | ||
| ) | ||
|
|
||
| // PassphraseFetcher recieves a keyname, and is responsible for returning the associated passphrase |
pkg/signature/keys.go
Outdated
|
|
||
| // Key returns the key with the given ID. | ||
| // | ||
| // ID is a hex ID or (conventionally) and email address. |
pkg/signature/keys.go
Outdated
| return nil, errors.New("multiple matching keys found") | ||
| } | ||
|
|
||
| // Save writes a keycring to disk as a binary entity list. |
| }() | ||
|
|
||
| newfile := filepath.Join(dirname, "save.gpg") | ||
| is.NoError(kr.Save(newfile, true)) |
There was a problem hiding this comment.
To thoroughly test clobber=true functionality, would we want to pre-create/pre-populate newfile before this Save?
pkg/signature/signature.go
Outdated
|
|
||
| // Signer can sign bundles | ||
| // | ||
| // Signatures are OpenPGP Section 7 clear signed blocks represented as ASCII-armored. |
There was a problem hiding this comment.
It seems the convention is clear signed be one word
pkg/signature/signature.go
Outdated
|
|
||
| // Attest generates an attestation (detached signature) for a signed bundle. | ||
| // | ||
| // This ONLY works on signed bundle files, and it rerequires the signed bundle |
pkg/signature/signature.go
Outdated
|
|
||
| // We clearsign instead of using the openpgp.ArmoredDetachedSignText because the | ||
| // later does not handle subkeys at all. It ONLY allows using the private key on | ||
| // the main entity. Yet all the helper methods for that are unexported. This it |
|
Addressed all of @vdice 's concerns |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
pkg/signature, which is a library for signing, attesting, and verifying bundles.I decided to do this as a standalone PR before adding signature support to all of the commands, as this is a fairly big addition.