Skip to content
This repository has been archived by the owner on May 3, 2022. It is now read-only.

feat(install): omitting the tag now fetches the latest semver tag #559

Merged
merged 1 commit into from
Dec 3, 2018
Merged

feat(install): omitting the tag now fetches the latest semver tag #559

merged 1 commit into from
Dec 3, 2018

Conversation

bacongobbler
Copy link
Contributor

@bacongobbler bacongobbler commented Nov 30, 2018

Given that you have the following bundles:

$ duffle bundle list
NAME            VERSION DIGEST                                          SIGNED?
helloworld      0.2.0   1d613da00b103a54cbe58d033904b1b9df877c2f        true
helloworld      0.1.0   824475e97a798263d3edda6bd23a58057860d17f        true

duffle bundle install test helloworld will now install v0.2.0.

Note: this now puts a constraint upon duffle where storing non-semver compatible versions in the local store is considered invalid. This was already the case before with duffle build:

$ duffle build .\examples\helloworld\
Error: cannot prepare build: Invalid Semantic Version

This can be worked around with the -f flag, however.

Signed-off-by: Matthew Fisher [email protected]

@bacongobbler
Copy link
Contributor Author

Closes #551

Copy link
Member

@vdice vdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though one unit test messaging question.

pkg/repo/index_test.go Outdated Show resolved Hide resolved
@bacongobbler bacongobbler merged commit 91cb690 into cnabio:master Dec 3, 2018
@bacongobbler bacongobbler deleted the get-latest-semver-bundle branch December 3, 2018 19:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants