This repository has been archived by the owner on May 3, 2022. It is now read-only.
Remove Docker socket from file mounts in driver #651
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
For Docker-app, when we detect we are deploying to the local docker-desktop engine, we'd like to be able to hook the ContainerConfig / HostConfig generated by the driver. I'll do a PR about that based on this current one (and duffle might also want to support a |
|
Closing as #661 included these changes. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #650
closes cnabio/cnab-spec#108
This PR simply removes the Docker socket.
We had an initial discussion during last week's standup, but I'll re-start it here: with the current implementation, the bundles that deployed Docker Compose files to the same daemon no longer work in their current state.
Should there be a way to run the invocation image as a privileged container in Duffle?