-
Notifications
You must be signed in to change notification settings - Fork 54
[feat-633-bundle-actions-cmd] Add bundle actions command #666
Conversation
b3de1c2
to
3aee353
Compare
Rebase from master and add all action fields Remove unused home field from actions cmd Remove unused skipValidation field in actions cmd
3aee353
to
c8cd03e
Compare
JSON output would be useful, thanks - I can parse space-separated lines, but when a value can contain spaces (here the description) it gets a bit messier. As a heads up, I believe users will find a field named 'stateless' a bit enigmatic; can we find a better name for this? If not, we should consider flipping it to 'stateful', because 'stateless: false' requires the reader to parse a double negative. 'modifies' is also a bit non-obvious though struggling to think of anything better. Finally what order guarantees do you give in this command? Is it the order of the JSON, alphabetical order, the order in which the Go map decides to spit them out this week? If we display these in a UI we will want a stable order though I can add that in the UI if we don't offer it in the CLI. |
|
Good point about the JSON - I can just do a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh this will be very helpful! two things:
- would you mind adding a tiny test?
- I refactored the UX on
export
&install
to always require an argument to the bundle. Someone can override the bundle argument to be a path with the-f
flag like here. Would it be okay to follow the same UX on this command as well?
@michelleN -- updated the UX for bundle reference and file, and added a tiny test. |
close #633
This PR adds a
duffle bundle actions
command that reads all actions from a bundle and displays them.To test this, the following bundle file can be used:
Alternatively, the bundle can be build, and/or signed using
duffle build
.cc @itowlson -- do you need this command to output JSON / other formats for the VS Code extension?