This repository has been archived by the owner on May 3, 2022. It is now read-only.
Fix linting on master #688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pin golangci-lint version in Makefile to prevent futur sudden linting errors if the tool is updated Signed-off-by: Silvin Lubecki <[email protected]>
ijc
approved these changes
Apr 1, 2019
michelleN
pushed a commit
to michelleN/duffle
that referenced
this pull request
Apr 5, 2019
The lint pass is failing on `master`, and the only reason I see is that `golangci-lint` was silently updated, as we always use the last version.
That's why I pinned the tool to the current version to prevent from futur failures.
Here is the output:
```
golangci-lint run --config ./golangci.yml
cmd/duffle/upgrade_test.go:31:4: composites: `github.com/deislabs/duffle/pkg/bundle.InvocationImage` composite literal uses unkeyed fields (govet)
{
^
pkg/action/action_test.go:40:4: composites: `github.com/deislabs/duffle/pkg/bundle.InvocationImage` composite literal uses unkeyed fields (govet)
{
^
pkg/packager/export.go:42:9: nilness: impossible condition: nil != nil (govet)
if err != nil {
^
pkg/packager/import.go:43:9: nilness: impossible condition: nil != nil (govet)
if err != nil {
^
make: *** [lint] Error 1
Makefile:74: recipe for target 'lint' failed
```
Signed-off-by: Silvin Lubecki <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The lint pass is failing on
master, and the only reason I see is thatgolangci-lintwas silently updated, as we always use the last version.That's why I pinned the tool to the current version to prevent from futur failures.
Here is the output:
Signed-off-by: Silvin Lubecki [email protected]