Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SH.REF.Export #122

Closed
3 tasks done
WaldoFR opened this issue Jun 14, 2018 · 1 comment · Fixed by #156
Closed
3 tasks done

SH.REF.Export #122

WaldoFR opened this issue Jun 14, 2018 · 1 comment · Fixed by #156
Assignees
@brigittehuynh
Labels
enhancement shell
Milestone
Version 3.1.0-alp...

Comments

@WaldoFR
Copy link

WaldoFR commented Jun 14, 2018 •
edited
Loading

Implementation of the rule SH.REF.Export.

Description

Function defined by a script must not be exported by itself.

State of the implementation

  • Violation raising
  • Localization
  • Unit tests
@WaldoFR WaldoFR modified the milestone: Version 3.1.0-alpha.1 Jun 15, 2018
brigittehuynh added a commit to brigittehuynh/i-CodeCNES that referenced this issue Jun 25, 2018
@brigittehuynh
cnescatlab#122 Added the SH.REF.Export rule
83a419f
brigittehuynh added a commit to brigittehuynh/i-CodeCNES that referenced this issue Jun 25, 2018
@brigittehuynh
cnescatlab#122 Added violation location and string handling and updat…
f12c2fa 
…ed unit tests

accordingly
@brigittehuynh
Copy link
Collaborator

Localization implemented and unit tests updated. The violations seem to be as expected, no correction.

@brigittehuynh brigittehuynh mentioned this issue Jun 25, 2018
Merged
brigittehuynh added a commit to brigittehuynh/i-CodeCNES that referenced this issue Jun 25, 2018
@brigittehuynh
cnescatlab#122 Changed the var format in EXPORT to the FNAME format t…
a660bb6 
…hat is better

adapted for a function name
brigittehuynh added a commit to brigittehuynh/i-CodeCNES that referenced this issue Jun 25, 2018
@brigittehuynh
cnescatlab#122 Updated a string and a comment to contain function to …
7635229 
…test that

strings and comments are handled correctly
@WaldoFR WaldoFR closed this as completed Jun 29, 2018
@WaldoFR WaldoFR mentioned this issue Sep 13, 2018
Merged
begarco pushed a commit to begarco/i-CodeCNES that referenced this issue Jan 25, 2020
@brigittehuynh
cnescatlab#122 Added the SH.REF.Export rule
ce1035c
begarco pushed a commit to begarco/i-CodeCNES that referenced this issue Jan 25, 2020
@brigittehuynh
cnescatlab#122 Added violation location and string handling and updat…
187193f 
…ed unit tests

accordingly
begarco pushed a commit to begarco/i-CodeCNES that referenced this issue Jan 25, 2020
@brigittehuynh
cnescatlab#122 Changed the var format in EXPORT to the FNAME format t…
636799a 
…hat is better

adapted for a function name
begarco pushed a commit to begarco/i-CodeCNES that referenced this issue Jan 25, 2020
@brigittehuynh
cnescatlab#122 Updated a string and a comment to contain function to …
cbb8f20 
…test that

strings and comments are handled correctly
begarco pushed a commit that referenced this issue Feb 2, 2020
@brigittehuynh
#122 Added the SH.REF.Export rule
7de9ca1
begarco pushed a commit that referenced this issue Feb 2, 2020
@brigittehuynh
#122 Added violation location and string handling and updated unit tests
12ca25f 
accordingly
begarco pushed a commit that referenced this issue Feb 2, 2020
@brigittehuynh
#122 Changed the var format in EXPORT to the FNAME format that is better
ca69774 
adapted for a function name
begarco pushed a commit that referenced this issue Feb 2, 2020
@brigittehuynh
#122 Updated a string and a comment to contain function to test that
de8f254 
strings and comments are handled correctly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brigittehuynh brigittehuynh

Labels
enhancement shell
Projects
None yet
Milestone
Version 3.1.0-alpha.1
Development

Successfully merging a pull request may close this issue.

v3.1.0 cnescatlab/i-CodeCNES
2 participants
@WaldoFR @brigittehuynh