Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] 在未请求成功阶段无法暂停问题 #181

Closed
dqzboy opened this issue May 5, 2024 · 4 comments
Closed

[Bug] 在未请求成功阶段无法暂停问题 #181

dqzboy opened this issue May 5, 2024 · 4 comments
Assignees
@Sh1n3zZ
Labels
improve version up Pro version features of the devolution of the open source version

Comments

@dqzboy
Copy link

dqzboy commented May 5, 2024 •
edited
Loading

在页面点击暂停回答没有任何反应，程序日志显示其实已经超时了，但是还是一直在转圈还不能暂停，如图
PixPin_2024-05-05_12-27-01
@zmh-program
Copy link
Member

这是因为 manager/chat 实现方法暂停其实是在流式响应的中途通过同步阻塞实现的，所以在请求发起之前会一直阻塞，不会处理stop signal，此时暂停是有问题的，后期我打算将其独立于一个goroutine中以快速暂停响应。

@dqzboy
Copy link
Author

dqzboy commented May 10, 2024

强👍

@zmh-program zmh-program changed the title 点击暂停按钮没有反应 [Bug] 在未请求成功阶段无法暂停问题 May 24, 2024
@Sh1n3zZ Sh1n3zZ assigned Sh1n3zZ and zmh-program and unassigned Sh1n3zZ Jun 21, 2024
@zmh-program
Copy link
Member

feat: better stop signal 商业版已率先修复，Waiting for @Sh1n3zZ 下放开源版

todo: https://github.com/Deeptrain-Community/chatnio-pro/commit/bdab26f989b10322ba2a74392e52760634c0e674

@zmh-program zmh-program added the version up Pro version features of the devolution of the open source version label Jun 27, 2024
@zmh-program zmh-program assigned Sh1n3zZ and unassigned zmh-program Jun 27, 2024
Sh1n3zZ added a commit that referenced this issue Jun 27, 2024
@Sh1n3zZ @zmh-program
feat: better stop signal (#181)
401de5a 
feat: better stop signal (#181)
Co-Authored-By: Minghan Zhang <[email protected]>
@Sh1n3zZ Sh1n3zZ closed this as completed Jun 27, 2024
@Sh1n3zZ
Copy link
Collaborator

Sh1n3zZ commented Jun 27, 2024

Hi,

Done.

Junhai Deng

@coaidev coaidev deleted a comment from Issues-translate-bot Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Sh1n3zZ Sh1n3zZ

Labels
improve version up Pro version features of the devolution of the open source version
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dqzboy @Sh1n3zZ @zmh-program