-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cobbler-Frontend: Implement Settings CRUD #89
Conversation
Codecov Report
@@ Coverage Diff @@
## main #89 +/- ##
==========================================
+ Coverage 22.93% 25.80% +2.86%
==========================================
Files 42 45 +3
Lines 1417 1461 +44
Branches 432 437 +5
==========================================
+ Hits 325 377 +52
+ Misses 1075 1064 -11
- Partials 17 20 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
348e253
to
9ad9849
Compare
The fix for the tests that the missing modules are imported should be split out tomorrow. |
02fbb22
to
8c0b3b3
Compare
I made huge progress for multiple things but I am not yet ready to commit something today. I have feedback from @agraul what I can improve and this is what I will try to focus on tomorrow. |
8c0b3b3
to
bda0078
Compare
bda0078
to
06a9ad3
Compare
I will try to address the remaining open points and clean the git history before I will merge this PR. |
06a9ad3
to
e22bd5b
Compare
This commit is currently incomplete as it does only define the margin for one device type (600-904px). The details have to be implemented at a later point according to: https://material.io/design/layout/understanding-layout.html#layout-anatomy
4732226
to
e3465af
Compare
3d70a7b
to
aef2894
Compare
Fixes #51
TODO:
Create- Implement Create, Update and Delete for Cobbler Settings #102Update- Implement Create, Update and Delete for Cobbler Settings #102Delete- Implement Create, Update and Delete for Cobbler Settings #102router-component
for tests