-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bots: Drop docker resolv.conf hack #9040
bots: Drop docker resolv.conf hack #9040
Conversation
c7ac63f
to
034497f
Compare
Wow, that actually worked everywhere. Triggering continuous-atomic, fedora-26, and fedora-testing to have the full spectrum. |
https://bugzilla.redhat.com/show_bug.cgi?id=1448331 apparently got fixed a while ago, and the hack is not necessary on any of our images any more. Also, the resolv.conf creation hack was duplicated in a lot of places. Should this still happen in some special case, let's only do this in the tests, not on the images, as they are much harder to change and clean up. Remove the hack from the Atomic images for now. It is still present in {debian,fedora,openshift,rhel,selenium}.setup, these will be rebuilt and cleaned up in separate pull requests. Closes cockpit-project#9040
034497f
to
d828cb1
Compare
image-refresh in progress on cockpit-tasks-sh8tm. |
I forgot, fedora-atomic is blocked by #9002. So let's only rebuild the other two atomics. |
image-refresh in progress on cockpit-tasks-mrr3b. |
image-refresh in progress on cockpit-tasks-fckv7. |
image-refresh fedora-atomic done: https://github.com/cockpituous/cockpit/commits/image-refresh-fedora-atomic-20180425-070202 |
image-refresh in progress on cockpit-tasks-sh8tm. |
image-refresh continuous-atomic done: https://github.com/cockpituous/cockpit/commits/image-refresh-continuous-atomic-20180425-070404 |
image-refresh in progress on cockpit-tasks-npcrk. |
image-refresh in progress on cockpit-tasks-zj9p4. |
image-refresh continuous-atomic done: https://github.com/cockpituous/cockpit/commits/image-refresh-continuous-atomic-20180425-071818 |
image-refresh in progress on cockpit-tasks-sh8tm. |
image-refresh rhel-atomic done: https://github.com/cockpituous/cockpit/commits/image-refresh-rhel-atomic-20180425-072828 |
image-refresh rhel-atomic done: https://github.com/cockpituous/cockpit/commits/image-refresh-rhel-atomic-20180425-074242 |
https://bugzilla.redhat.com/show_bug.cgi?id=1448331 apparently got fixed a while ago, and the hack is not necessary on any of our images any more. Also, the resolv.conf creation hack was duplicated in a lot of places. Should this still happen in some special case, let's only do this in the tests, not on the images, as they are much harder to change and clean up. Remove the hack from the Atomic images for now. It is still present in {debian,fedora,openshift,rhel,selenium}.setup, these will be rebuilt and cleaned up in separate pull requests. Closes cockpit-project#9040
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
https://bugzilla.redhat.com/show_bug.cgi?id=1448331 apparently got fixed a while ago, and the hack is not necessary on any of our images any more. Also, the resolv.conf creation hack was duplicated in a lot of places. Should this still happen in some special case, let's only do this in the tests, not on the images, as they are much harder to change and clean up. Remove the hack from the Atomic images for now. It is still present in {debian,fedora,openshift,rhel,selenium}.setup, these will be rebuilt and cleaned up in separate pull requests. Closes #9040
https://bugzilla.redhat.com/show_bug.cgi?id=1448331 apparently got fixed
a while ago, and the hack is not necessary on any of our images any
more. Also, the resolv.conf creation hack was duplicated in a lot of
places.
Should this still happen in some special case, let's only do this in the
tests, not on the images, as they are much harder to change and clean
up.
Remove the hack from the Atomic images for now. It is still present in
{debian,fedora,openshift,rhel,selenium}.setup, these will be rebuilt and
cleaned up in separate pull requests.