teamcity: failed test: TestLint (oom in TestVet)

[cockroach-teamcity]

The following tests appear to have failed on master (lint): TestLint/TestVet: TestLint/TestVet/shadow, TestLint/TestVet, TestLint

You may want to check for open issues.

#1257210:

TestLint
--- FAIL: lint/TestLint (271.190s)




TestLint/TestVet: TestLint/TestVet/shadow
...0, 0xaf9efc, 0xc0025093f8, 0x0)
            lint_test.go:1308: 
                	/usr/local/go/src/cmd/compile/internal/gc/order.go:359 +0x375 fp=0xc002509120 sp=0xc002509030 pc=0xafa365
            lint_test.go:1308: 
                cmd/compile/internal/gc.(*Order).callArgs(0xc0025093f8, 0xc00054e320)
            lint_test.go:1308: 
                	/usr/local/go/src/cmd/compile/internal/gc/order.go:368 +0x6c fp=0xc002509170 sp=0xc002509120 pc=0xafa5dc
            lint_test.go:1308: 
                cmd/compile/internal/gc.(*Order).stmt(0xc0025093f8, 0xc00054e300)
            lint_test.go:1308: 
                	/usr/local/go/src/cmd/compile/internal/gc/order.go:752 +0x1b91 fp=0xc002509398 sp=0xc002509170 pc=0xafcd61
            lint_test.go:1308: 
                cmd/compile/internal/gc.(*Order).stmtList(0xc0025093f8, 0xc000744660)
            lint_test.go:1308: 
                	/usr/local/go/src/cmd/compile/internal/gc/order.go:267 +0x58 fp=0xc0025093d0 sp=0xc002509398 pc=0xaf9a28
            lint_test.go:1308: 
                cmd/compile/internal/gc.orderBlock(0xc003fd3b98)
            lint_test.go:1308: 
                	/usr/local/go/src/cmd/compile/internal/gc/order.go:276 +0x4e fp=0xc002509438 sp=0xc0025093d0 pc=0xaf9aae
            lint_test.go:1308: 
                cmd/compile/internal/gc.order(0xc003fd3b80)
            lint_test.go:1308: 
                	/usr/local/go/src/cmd/compile/internal/gc/order.go:57 +0x3f fp=0xc002509490 sp=0xc002509438 pc=0xaf884f
            lint_test.go:1308: 
                cmd/compile/internal/gc.compile(0xc003fd3b80)
            lint_test.go:1308: 
                	/usr/local/go/src/cmd/compile/internal/gc/pgen.go:218 +0x4f fp=0xc0025094e0 sp=0xc002509490 pc=0xb02a7f
            lint_test.go:1308: 
                cmd/compile/internal/gc.funccompile(0xc003fd3b80)
            lint_test.go:1308: 
                	/usr/local/go/src/cmd/compile/internal/gc/pgen.go:209 +0xbd fp=0xc002509538 sp=0xc0025094e0 pc=0xb0293d
            lint_test.go:1308: 
                cmd/compile/internal/gc.genwrapper(0xc00304bbc0, 0xc0030832c0, 0xc003ff58c0)
            lint_test.go:1308: 
                	/usr/local/go/src/cmd/compile/internal/gc/subr.go:1719 +0x5c9 fp=0xc0025096a8 sp=0xc002509538 pc=0xb6a989
            lint_test.go:1308: 
                cmd/compile/internal/gc.imethods(0xc00304bbc0, 0xc003fbb5e0, 0x3, 0xc00070fee0)
            lint_test.go:1308: 
                	/usr/local/go/src/cmd/compile/internal/gc/reflect.go:459 +0x214 fp=0xc002509780 sp=0xc0025096a8 pc=0xb1d394
            lint_test.go:1308: 
                cmd/compile/internal/gc.genfun(0xc003242a20, 0xc00304bbc0, 0xc00070fee0, 0x3, 0x3)
            lint_test.go:1308: 
                	/usr/local/go/src/cmd/compile/internal/gc/reflect.go:1392 +0x79 fp=0xc002509838 sp=0xc002509780 pc=0xb22909
            lint_test.go:1308: 
                cmd/compile/internal/gc.peekitabs()
            lint_test.go:1308: 
                	/usr/local/go/src/cmd/compile/internal/gc/reflect.go:1377 +0x90 fp=0xc002509890 sp=0xc002509838 pc=0xb22820
            lint_test.go:1308: 
                cmd/compile/internal/gc.Main(0xcc51f8)
            lint_test.go:1308: 
                	/usr/local/go/src/cmd/compile/internal/gc/main.go:632 +0x25d2 fp=0xc002509f20 sp=0xc002509890 pc=0xadd172
            lint_test.go:1308: 
                main.main()
            lint_test.go:1308: 
                	/usr/local/go/src/cmd/compile/main.go:51 +0x96 fp=0xc002509f98 sp=0xc002509f20 pc=0xbfaa36
            lint_test.go:1308: 
                runtime.main()
            lint_test.go:1308: 
                	/usr/local/go/src/runtime/proc.go:201 +0x207 fp=0xc002509fe0 sp=0xc002509f98 pc=0x42c4a7
            lint_test.go:1308: 
                runtime.goexit()
            lint_test.go:1308: 
                	/usr/local/go/src/runtime/asm_amd64.s:1333 +0x1 fp=0xc002509fe8 sp=0xc002509fe0 pc=0x457da1



TestLint/TestVet
--- FAIL: lint/TestLint: TestLint/TestVet (865.860s)

------- Stdout: -------
=== PAUSE TestLint/TestVet

Please assign, take a look and update the issue accordingly.

[tbg]

Doesn't seem to be tracked anywhere, which is bad given that it's such an annoyance. Ok, who's going to do $SOMETHING about it? I think @jordanlewis and @RaduBerinde have looked at this most recently. Was anything tried already? Also cc @bobvawter

[RaduBerinde]

Hopefully this lands soon: dominikh/go-tools#376

[tbg]

The current hope is to finalize the port in June, give it intense internal testing, then release a version for public testing, before finally merging it into master, some time in July or August.

That means we need to do something in the meantime. I started looking into this but it really feels that most of what I would be doing has already been done and what's needed first is a braindump. What's consuming the most memory? Is it running in parallel with anything else? Have we considered just giving the TC agents more memory or enabling swap? Etc. Can someone clue me in?

[RaduBerinde]

The problematic tests (Unused, Megacheck) don't run in parallel with other tests. Sure, giving agents more memory would help. We can also try using GOGC=50.

It looks like dominikh just posted about a branch with his latest work. We could try running against that (we'll need to update our code though, see the patch linked in #33669)

[RaduBerinde]

I took a look at using the latest branch. The interfaces have changed a lot again, and there's not much in the way of documentation/comments. It would probably require a week of someone banging their head against it.

[dominikh]

and there's not much in the way of documentation/comments. It would probably require a week of someone banging their head against it.

Documentation will follow soon (certainly by the time the code lands in master.)

[RaduBerinde]

Thanks @dominikh! For what it's worth, I think we've went too far with using the internal libraries. I think it would be reasonable to just run staticcheck directly, and later we can look at adding some of our custom checks.

[RaduBerinde]

I will look at replacing TestUnused and TestMegacheck with the newest staticcheck. I can comment out our custom checks and leave them as a future TODO