-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vendor: add deps of binary tools/utils #11665
Conversation
Reproducing on a fresh gceworker, will update with the results. Review status: 0 of 3 files reviewed at latest revision, all discussions resolved, some commit checks failed. Comments from Reviewable |
a couple of these got dropped when we recomputed deps from source, since they aren't transitive deps of cockroach, only of tools we use
vendor/github.com/robfig/glock/sync.go:11:2: cannot find package "github.com/agtorre/gocolorize" in any of: Review status: 0 of 3 files reviewed at latest revision, all discussions resolved, some commit checks pending. Comments from Reviewable |
LGTM |
I just newly fetched the code and those were the only three dependencies. LGTM |
Reviewed 3 of 3 files at r1. glide.yaml, line 13 at r1 (raw file):
why remove these comments? Comments from Reviewable |
Review status: all files reviewed at latest revision, 1 unresolved discussion, all commit checks successful. glide.yaml, line 13 at r1 (raw file): Previously, tamird (Tamir Duberstein) wrote…
They're auto-removed any time Comments from Reviewable |
Review status: all files reviewed at latest revision, 1 unresolved discussion, all commit checks successful. glide.yaml, line 13 at r1 (raw file): Previously, dt (David Taylor) wrote…
The gift that keeps on giving. Comments from Reviewable |
Wait, so you decided not to restore those comments? Sigh. |
@tamird filed an issue upstream about that, though looking at the lib they use, go-yaml, i'm not sure there's anyway to parse and capture comment nodes, so i'm not holding my breath. |
I also filed one for the more general issue of our vendored tools missing their transitive deps: |
a couple of these got dropped when we recomputed deps from source, since they aren't transitive deps of cockroach,
only of tools we use
This change is