roachprod: fix default backup schedule creation on start #118368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For a while now, `roachprod` has created a default backup schedule on cluster creation when `--schedule-backups` is passed. This is also the default in clusters created to run roachtests. When we fixed an issue with starting external-process tenants in 3715eb5, however, we unadvertently changed the order of two operations performed by roachprod on cluster start: setting the default cluster settings, and creating the default backup schedule. As a consequence, the command used to create the backup schedule fails because, at that point, we haven't configured a license key yet. To make matters worse, there was a bug in the error handling of `createFixedBackupSchedule` that prevented errors from being reported to the user; these errors were being swallowed and went unnoticed for a few months. In this commit, we fix the error checking in that function, and also officially remove code that partially supported creating backups or admin users in tenants. Currently, roachprod will run that part of the setup for the system tenant. In the future, we might revisit this and also create a backup schedule and admin users for application tenants. Epic: none Release note: None
|
This change is |
|
Running a |
renatolabs
requested review from
herkolategan and
srosenberg
and removed request for
a team
|
Run above looks normal; failures are unrelated and also happen on master. |
renatolabs
added
backport-23.1.x
herkolategan
approved these changes
Jan 30, 2024
|
TFTR! bors r=herkolategan |
|
Build succeeded: |
This was referenced Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a while now,
roachprodhas created a default backup schedule on cluster creation when--schedule-backupsis passed. This is also the default in clusters created to run roachtests.When we fixed an issue with starting external-process tenants in 3715eb5, however, we unadvertently changed the order of two operations performed by roachprod on cluster start: setting the default cluster settings, and creating the default backup schedule.
As a consequence, the command used to create the backup schedule fails because, at that point, we haven't configured a license key yet.
To make matters worse, there was a bug in the error handling of
createFixedBackupSchedulethat prevented errors from being reported to the user; these errors were being swallowed and went unnoticed for a few months.In this commit, we fix the error checking in that function, and also officially remove code that partially supported creating backups or admin users in tenants. Currently, roachprod will run that part of the setup for the system tenant. In the future, we might revisit this and also create a backup schedule and admin users for application tenants.
Epic: none
Release note: None