kvserver: increase shutdown propagation time in range merge test #118482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`TestStoreRangeMergeDuringShutDown` could occasionally flake when the shutdown hadn't propagated before applying the lease. Increase the post-shutdown sleep from 10ms to 20ms. Fixes: cockroachdb#118348 Release note: None
|
This change is |
kvoli
added
backport-23.1.x
|
I noticed this when I was working on some of my other shutdown code, but think the root problem is that there is a sleep here at all. I wonder if there is a way to restructure this test to use a different approach. I didn't change this since it was fairly deep in the code where this happens, and I wasn't sure where else to hook into. I agree that bumping this timeout will likely resolve the issue. |
|
TYFTR bors r=andrewbaptist |
|
Build succeeded: |
This was referenced Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TestStoreRangeMergeDuringShutDowncould occasionally flake when the shutdown hadn't propagated before applying the lease.Increase the post-shutdown sleep from 10ms to 20ms.
Fixes: #118348
Release note: None