Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roachpb: increase test make priority trials #118483

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

kvoli
Copy link
Collaborator

@kvoli kvoli commented Jan 30, 2024

TestMakePriority could (very) rarely flake due to slight differences in the sampled vs underlying distribution. Increase the trial runs by 33% from 750k to 1000k to reduce the likelihood of this occurring.

Fixes: #118399
Release note: None

`TestMakePriority` could (very) rarely flake due to slight differences
in the sampled vs underlying distribution. Increase the trial runs by
33% from 750k to 1000k to reduce the likelihood of this occurring.

Fixes: cockroachdb#118399
Release note: None
@kvoli kvoli self-assigned this Jan 30, 2024
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@kvoli kvoli added the backport-23.2.x Flags PRs that need to be backported to 23.2. label Jan 30, 2024
@kvoli kvoli marked this pull request as ready for review January 30, 2024 17:47
@kvoli kvoli requested a review from a team as a code owner January 30, 2024 17:47
@kvoli kvoli requested a review from andrewbaptist January 30, 2024 18:04
Copy link
Collaborator

@andrewbaptist andrewbaptist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@kvoli
Copy link
Collaborator Author

kvoli commented Jan 30, 2024

TYFTR

bors r=andrewbaptist

@craig
Copy link
Contributor

craig bot commented Jan 30, 2024

Build succeeded:

@craig craig bot merged commit 38dd16a into cockroachdb:master Jan 30, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-23.2.x Flags PRs that need to be backported to 23.2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

roachpb: TestMakePriority failed
3 participants