Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jobs,application_api: replace calls to skip.Stress with skip.Duress #118789

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

rickystewart
Copy link
Collaborator

skip.Duress() seems like it should have been used in this case as it gives more time under both race and deadlock. This will give these tests some extra time if they run in a heavyweight configuration but not "under stress".

Epic: CRDB-8308
Release note: None

@rickystewart rickystewart requested a review from rail February 5, 2024 22:33
@rickystewart rickystewart requested review from a team as code owners February 5, 2024 22:33
@rickystewart rickystewart requested review from msbutler and removed request for a team February 5, 2024 22:33
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Collaborator

@celiala celiala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - makes sense to me

@rickystewart
Copy link
Collaborator Author

bors r=celiala

@craig
Copy link
Contributor

craig bot commented Feb 5, 2024

🕐 Waiting for PR status (GitHub check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set.

`skip.Duress()` seems like it should have been used in this case as it
gives more time under both `race` and `deadlock`. This will give these
tests some extra time if they run in a heavyweight configuration but not
"under stress".

Epic: CRDB-8308
Release note: None
@rickystewart
Copy link
Collaborator Author

bors r=celiala

@craig
Copy link
Contributor

craig bot commented Feb 5, 2024

Stopped waiting for PR status (GitHub check) without running due to duplicate requests to run. You may check Bors to see that this PR is included in a batch by one of the other requests.

@craig
Copy link
Contributor

craig bot commented Feb 6, 2024

Build succeeded:

@craig craig bot merged commit 804d37e into cockroachdb:master Feb 6, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants