-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-23.2: sql: fix flake in TestTxnContentionEventsTable #118808
Conversation
In causeContention we deliberately hold a transaction open using pg_sleep to block an update statement. The timing we're trying to achieve is: 1. transaction insert 2. update starts and blocks 3. transaction held open using pg_sleep We were using a WaitGroup to order (2) after (1), but there was no synchronization to ensure (3) came after (2). This commit adds a retry loop that checks `crdb_internal.cluster_queries` to ensure (3) comes after (2). Fixes: #118236 Release note: None
ea90edf
to
a0cb448
Compare
Thanks for opening a backport. Please check the backport criteria before merging:
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
Also, please add a brief release justification to the body of your PR to justify this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @mgartner and @michae2)
This is a test-only change. Merging. |
Backport 1/1 commits from #118372 on behalf of @michae2.
/cc @cockroachdb/release
In causeContention we deliberately hold a transaction open using pg_sleep to block an update statement. The timing we're trying to achieve is:
We were using a WaitGroup to order (2) after (1), but there was no synchronization to ensure (3) came after (2).
This commit adds a retry loop that checks
crdb_internal.cluster_queries
to ensure (3) comes after (2).Fixes: #118236
Release note: None
Release justification: test-only fix for a flake.