Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: upgrade [email protected] to version 1.43.1 #133563

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

wenyihu6
Copy link
Contributor

@wenyihu6 wenyihu6 commented Oct 28, 2024

This patch upgrades sarama to v1.43.1 to pick up fix IBM/sarama#2826 related to the kafka
throttling feature we supported in v24.1. It addresses a race condition where
producer could be blocked.

Epic: none

Release note: fixed a race condition in sarama when kafka throttling is
enabled

@cockroach-teamcity
Copy link
Member

This change is Reviewable

This patch upgrades sarama to v1.43.1 to pick up fix IBM/sarama#2826 related to the kafka
throttling feature we supported in v24.1. It addresses a race condition where
producer could be blocked.

Epic: none

Release note: fixed a race condition in sarama when kafka throttling is
enabled

Epic: none

Release note: fixed a race condition in sarama when kafka throttling is
enabled
@wenyihu6 wenyihu6 marked this pull request as ready for review October 28, 2024 15:55
@wenyihu6 wenyihu6 requested a review from a team as a code owner October 28, 2024 15:55
@wenyihu6 wenyihu6 requested a review from rharding6373 October 28, 2024 15:55
@rharding6373
Copy link
Collaborator

sarama's changelog isn't up-to-date. I looked at a diff of the changes between 1.42.1 and 1.43.1 and it looks like the changes are minor except for 2 bug fixes (IBM/sarama@v1.42.1...v1.43.1).

LGTM Thanks for tracking this Wenyi!

@wenyihu6
Copy link
Contributor Author

wenyihu6 commented Oct 29, 2024

Thanks for checking the diff between the two versions! Are we okay with backporting this?

@rharding6373
Copy link
Collaborator

Yes, I think we should backport. Given the few changes in the diff it seems like a lowish risk highish reward situation.

@wenyihu6 wenyihu6 added the backport-24.1.x Flags PRs that need to be backported to 24.1. label Oct 29, 2024
@wenyihu6
Copy link
Contributor Author

TFTR!

bors r=rharding6373

@wenyihu6
Copy link
Contributor Author

bors retry

@craig craig bot merged commit 919c90c into cockroachdb:master Oct 29, 2024
23 checks passed
Copy link

blathers-crl bot commented Oct 29, 2024

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.


error creating merge commit from ca0b43d to blathers/backport-release-24.1-133563: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 24.1.x failed. See errors above.


🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-24.1.x Flags PRs that need to be backported to 24.1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants