-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: upgrade [email protected] to version 1.43.1 #133563
Conversation
4dad368
to
7c46840
Compare
This patch upgrades sarama to v1.43.1 to pick up fix IBM/sarama#2826 related to the kafka throttling feature we supported in v24.1. It addresses a race condition where producer could be blocked. Epic: none Release note: fixed a race condition in sarama when kafka throttling is enabled Epic: none Release note: fixed a race condition in sarama when kafka throttling is enabled
7c46840
to
ca0b43d
Compare
sarama's changelog isn't up-to-date. I looked at a diff of the changes between 1.42.1 and 1.43.1 and it looks like the changes are minor except for 2 bug fixes (IBM/sarama@v1.42.1...v1.43.1). LGTM Thanks for tracking this Wenyi! |
Thanks for checking the diff between the two versions! Are we okay with backporting this? |
Yes, I think we should backport. Given the few changes in the diff it seems like a lowish risk highish reward situation. |
TFTR! bors r=rharding6373 |
bors retry |
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error creating merge commit from ca0b43d to blathers/backport-release-24.1-133563: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 24.1.x failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
This patch upgrades sarama to v1.43.1 to pick up fix IBM/sarama#2826 related to the kafka
throttling feature we supported in v24.1. It addresses a race condition where
producer could be blocked.
Epic: none
Release note: fixed a race condition in sarama when kafka throttling is
enabled