Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update golang.org/x deps #32922

Merged
merged 1 commit into from
Dec 7, 2018
Merged

Update golang.org/x deps #32922

merged 1 commit into from
Dec 7, 2018

Conversation

@RaduBerinde RaduBerinde requested review from benesch, petermattis and a team December 7, 2018 02:41
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@RaduBerinde RaduBerinde requested a review from tbg December 7, 2018 15:58
@tbg
Copy link
Member

tbg commented Dec 7, 2018

Did you go through the changelogs? I looked at crypto (thankfully very short), but not the others.

@tbg
Copy link
Member

tbg commented Dec 7, 2018

LGTM
sys is long, skimmed it less thoroughly (>200 commits)
tools is massive (474 commits), didn't look

@RaduBerinde
Copy link
Member Author

Thanks! I made a pass through them as well, had to kind of skim through sys and tools.

bors +

@RaduBerinde
Copy link
Member Author

bors r+

craig bot pushed a commit that referenced this pull request Dec 7, 2018
@craig
Copy link
Contributor

craig bot commented Dec 7, 2018

Build succeeded

@craig craig bot merged commit e871ee3 into cockroachdb:master Dec 7, 2018
@RaduBerinde RaduBerinde deleted the update-go-x branch December 7, 2018 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants