Update gRPC deps #32961
Merged
Update gRPC deps #32961
+27
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
RaduBerinde
force-pushed
the
update-grpc
branch
from
d5a6b0e to
f316d2a
Compare
tbg
approved these changes
Dec 10, 2018
There was a problem hiding this comment.
LGTM, though the first grpc-opentracing link is 404. I did review all other commit ranges and nothing stood out.
Reviewed 6 of 6 files at r1.
Reviewable status:complete! 0 of 0 LGTMs obtained
Fixed. |
Changes: grpc-ecosystem/grpc-gateway@07f5e79...9258377 grpc/grpc-go@8f06f82...168a619 For grpc-opentracing, only three commits touch `otgrpc`: - grpc-ecosystem/grpc-opentracing@a20eba0 - grpc-ecosystem/grpc-opentracing@2a9f1a4 - grpc-ecosystem/grpc-opentracing@151e1e2 Informs cockroachdb#30774. Release note: None
RaduBerinde
force-pushed
the
update-grpc
branch
from
f316d2a to
7715448
Compare
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Dec 10, 2018
32961: Update gRPC deps r=RaduBerinde a=RaduBerinde Changes: - grpc-ecosystem/grpc-gateway@07f5e79...9258377 - grpc/grpc-go@8f06f82...168a619 For grpc-opentracing, only three commits touch `otgrpc`: - grpc-ecosystem/grpc-opentracing@a20eba0 - grpc-ecosystem/grpc-opentracing@2a9f1a4 - grpc-ecosystem/grpc-opentracing@151e1e2 Informs #30774. Release note: None I looked through the changes but would appreciate another look. Co-authored-by: Radu Berinde <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
For grpc-opentracing, only three commits touch
otgrpc:Informs #30774.
Release note: None
I looked through the changes but would appreciate another look.