Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

builder: upgrade to go1.11.4 #33668

Merged
merged 1 commit into from
Jan 14, 2019
Merged

builder: upgrade to go1.11.4 #33668

merged 1 commit into from
Jan 14, 2019

Conversation

petermattis
Copy link
Collaborator

Bump the minimum version to go1.11.

Fixes #33283

Release note (general change): Upgrade the build environment to use
go1.11.4.

@petermattis petermattis requested a review from a team January 11, 2019 16:20
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@petermattis petermattis requested review from bdarnell and tbg January 11, 2019 16:20
RaduBerinde
RaduBerinde approved these changes Jan 11, 2019
View reviewed changes
Copy link
Member

@RaduBerinde RaduBerinde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained

@petermattis
Copy link
Collaborator Author

Green on the first try. Impossible!

@RaduBerinde
Copy link
Member

Did it run with 1.10 or with 1.11 in TeamCity?

I get some TestLint/TestReturnCheck failures in the standard library with make lint locally. Does it work for you?

@petermattis
Copy link
Collaborator Author

@RaduBerinde I'm pretty sure it ran 1.11 on teamcity. Let me see if I can verify which builder image it used.

make lint works locally for me. Hmm, I wonder if I should nuke my bin directory so that it rebuilds all the linters.

@RaduBerinde
Copy link
Member

Oh. I think that the errors I saw didn't actually cause the test to fail (I had other errors in my tree). Let me investigate more.

@petermattis
Copy link
Collaborator Author

I just nuked my bin and make lint passed fine locally. I'm definitely running go1.11.4 locally.

@petermattis
Copy link
Collaborator Author

Also, I didn't see any errors.

@RaduBerinde
Copy link
Member

It passes for me too now.. I must have had an old version (all the errors were related to an arch that's new in go 1.11). Sorry for the noise.

@petermattis
Copy link
Collaborator Author

Great. No worries about the noise. I'd rather do extra checks on a PR like this, than break the world.

@petermattis
builder: upgrade to go1.11.4
779d974 
Bump the minimum version to go1.11.

Fixes cockroachdb#33283

Release note (general change): Upgrade the build environment to use
go1.11.4.
@RaduBerinde
Copy link
Member

Just as a heads-up:

@petermattis
Copy link
Collaborator Author

bors r=RaduBerinde

craig bot pushed a commit that referenced this pull request Jan 14, 2019
@petermattis
Merge #33668
af6f64c 
33668: builder: upgrade to go1.11.4 r=RaduBerinde a=petermattis

Bump the minimum version to go1.11.

Fixes #33283

Release note (general change): Upgrade the build environment to use
go1.11.4.

Co-authored-by: Peter Mattis <[email protected]>
@craig
Copy link
Contributor

craig bot commented Jan 14, 2019

Build succeeded

@craig craig bot merged commit 779d974 into cockroachdb:master Jan 14, 2019
@RaduBerinde
Copy link
Member

🎉

@petermattis petermattis deleted the pmattis/go1.11.4 branch January 15, 2019 21:04
@jseldess jseldess mentioned this pull request Feb 12, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RaduBerinde RaduBerinde RaduBerinde approved these changes

@bdarnell bdarnell Awaiting requested review from bdarnell

@tbg tbg Awaiting requested review from tbg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@petermattis @cockroach-teamcity @RaduBerinde